Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds toggle functionality to the publish button in PlanView that shows different icons based on publish status, and updates ScriptureTable's publish button handler to toggle between published and unpublished states.
Changes:
- Modified publish button in PlanView to display PublishOffIcon when published and PublishOnIcon when not published
- Updated ScriptureTable's handleOpenPublishDialog to toggle publish state based on current status
- Added comprehensive test coverage for the new publish button functionality in PlanView
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/renderer/src/components/Sheet/ScriptureTable.tsx | Added toggle logic to handleOpenPublishDialog to unpublish or publish based on current state; added hidePublishing to useMemo dependencies; minor formatting improvement |
| src/renderer/src/components/Sheet/PlanView.tsx | Added PublishOffIcon import and usePublishDestination hook; implemented conditional icon rendering based on publish status |
| src/renderer/src/components/Sheet/PlanView.cy.tsx | Added comprehensive test coverage for publish button icon states and interactions across various scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gtryus
force-pushed
the
feature/TT-7019-publish-button
branch
2 times, most recently
from
7a51d2e to
2c939a8
Compare
sarahentzel
approved these changes
Jan 15, 2026
…ureTable components - Refactor ConfirmPublishDialog to utilize context and improve string handling for media and plan publishing. Remove unnecessary props and integrate new selectors for better state management. - Display dialog for publish options - Refactor PlanView to replace handleOpenPublishDialog with handlePublish, enhancing publish functionality and integrating confirmation dialog for publishing actions. - Update localized strings for improved user feedback during publishing.
gtryus
force-pushed
the
feature/TT-7019-publish-button
branch
from
2c939a8 to
02479f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.