Fix segments thinking they have changed when switching steps#203
Merged
Fix segments thinking they have changed when switching steps#203
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses unintended “segments changed” behavior when switching steps by suppressing region callbacks during WaveSurfer teardown.
Changes:
- Add a destroy/teardown guard (
destroyingRef+prepareForDestroy) to prevent region-removed side effects during destroy/unmount. - Hook WaveSurfer
destroy/unmount paths to set the destroy guard and adjust region clearing behavior. - Reduce
controlsRefeffect dependencies and clean up minor lint/comment noise.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/renderer/src/crud/useWavesurferRegions.tsx |
Introduces destroyingRef + prepareForDestroy and guards region-removed follow-up work during teardown. |
src/renderer/src/crud/useWaveSurfer.tsx |
Calls prepareForDestroy() on WaveSurfer destroy/unmount; changes how clearRegions is invoked from wsClear. |
src/renderer/src/components/WSAudioPlayer.tsx |
Changes controlsRef setup effect dependency handling (now lint-disabled and reduced deps). |
src/renderer/src/components/App/HeadStatus.tsx |
Removes an unnecessary exhaustive-deps disable comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.