Update LfMergeBridge tests to new comments API #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New API passes LfComment lists directly rather than serialized to JSON, so the tests need to do the same.
Contributor
Author
hahn-kev
approved these changes
Dec 2, 2024
Test Results879 tests 765 ✅ 3m 25s ⏱️ For more details on these failures and errors, see this check. Results for commit 6e93eb5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New API (introduced in #401 and #402) for LfMergeBridge passes LfComment lists directly rather than serialized to JSON, so the tests need to do the same.
Fixes #415.
This change is