add remote resource support #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahn-kev
force-pushed
the
remote-resources
branch
2 times, most recently
from
5f64c2a to
8f29622
Compare
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
Do we need to add anything more to the sample model to demonstrate expected use? Maybe in a follow up?
Collaborator
Author
|
Yeah that's a good idea. Maybe I'll just make an attached file to the Word entity. |
…evant. Update db model snapshot test add remote resources support. add method to upload all pending local resources, and call from SyncWithResourceUpload helper method
hahn-kev
force-pushed
the
remote-resources
branch
from
e7b004c to
034c3dc
Compare
# Conflicts: # src/SIL.Harmony/DataModel.cs # src/SIL.Harmony/Db/CrdtRepository.cs
myieye
approved these changes
Nov 28, 2024
Contributor
myieye
left a comment
myieye
left a comment
There was a problem hiding this comment.
Nice work here 👍 💪
I just have a few thoughts 💭
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
myieye
reviewed
Dec 4, 2024
…e but don't cancel and mark the upload as pending
# Conflicts: # src/SIL.Harmony.Tests/SIL.Harmony.Tests.csproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the purpose of this is to investiage how to connect CRDTs and binary files (called resources here) which can't easily be stored as a CRDT directly.
Basically there's RemoteResources, these a tracked in CRDTs and can be referenced by other objects. They contain a reference to a resource on a remote server (auth left up to the app). Then there's a LocalResource, this represents a resource stored locally. There are 3 states a resource can be in.
if the file is local only then the RemoteResource.RemoteId will be null, indicating it has not yet been uploaded.
if DataModel.GetLocalResource returns null that means the resource has not yet been downloaded.
There are 2 apis to help the application list resources that are pending upload or pending download.
There is also an API to help upload resources before a sync.