Project only the latest snapshot of each entity in a single batch #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myieye
commented
Jan 29, 2025
hahn-kev
reviewed
Jan 30, 2025
hahn-kev
approved these changes
Jan 30, 2025
… a difference which was used
…the update failed on and the error message
…s in a root snapshot that was created during this snapshot update
myieye
force-pushed
the
introduce-snapshot-scope
branch
from
715d08a to
67126f0
Compare
myieye
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem that if in a single sync:
We add all the root snapshots first and immediately project them as we add them, and end up trying to project 2 complex-form-components that violate our unique constraint.
The additional tests I added were failing while SaveChanges was inside the loop in the new
SnapshotsAdded()(as also decsribed in my comment below). They don't fail when it's outside the loop. So, maybe they add no value.