Allow recording and saving audio #1836

hahn-kev · 2025-07-22T02:57:38Z

Important

recording/uploading audio is still hidden behind the dev flag until we handle file conversion.

Implements:

saving audio files for FwData projects to disk
saving audio locally for Harmony projects
uploading audio for Harmony projects, either during save (when online) or during sync.
gql query to list media files in lexbox, used for testing only for now
fix issues with JS Interop, should now be able to pass js objects as a ref to .net and dotnet can call methods on them

…e to how the slider works

…type

coderabbitai · 2025-07-22T02:57:45Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

This update introduces a comprehensive media file management feature across the backend and frontend. It adds new types, APIs, GraphQL queries, and TypeScript interfaces for handling file uploads, metadata, and queries. The backend supports file saving, uploading, and synchronization, while the frontend enables users to upload, validate, and manage audio files with real-time feedback and improved integration with .NET services.

Changes

Files / Areas	Change Summary
backend/FwHeadless/LexboxFwDataMediaAdapter.cs, backend/FwLite/FwDataMiniLcmBridge.Tests/MediaFileTests.cs, backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateDictionaryProxy.cs, backend/FwLite/FwDataMiniLcmBridge/Media/IMediaAdapter.cs, backend/FwLite/MiniLcm/IMiniLcmReadApi.cs, backend/Testing/FwHeadless/MediaFileServiceTests.cs	Added `using MiniLcm.Media;` directive for access to media types; updated methods to require absolute paths and nullable returns for media URI path resolution.
backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs, backend/FwLite/FwDataMiniLcmBridge/Media/LocalMediaAdapter.cs, backend/FwLite/FwLiteShared/Services/MiniLcmJsInvokable.cs, backend/FwLite/FwLiteShared/Sync/SyncService.cs, backend/FwLite/FwLiteShared/TypeGen/ReinforcedFwLiteTypingConfig.cs, backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs, backend/FwLite/LcmCrdt/MediaServer/IMediaServerClient.cs, backend/FwLite/LcmCrdt/MediaServer/LcmMediaService.cs, backend/FwLite/MiniLcm/IMiniLcmWriteApi.cs	Added or updated methods for saving, uploading, and synchronizing media files; introduced new types and refactored logic for media handling and API integration, including async file save/upload and MIME type folder mapping.
backend/FwLite/MiniLcm/Media/FileMetadata.cs, backend/FwLite/MiniLcm/Media/MediaFile.cs, backend/FwLite/MiniLcm/Media/MediaUri.cs, backend/FwLite/MiniLcm/Media/ReadFileResponse.cs, backend/FwLite/MiniLcm/Media/UploadFileResponse.cs, backend/FwLite/MiniLcm/Media/StreamUtils.cs	Introduced or updated record types and enums for media file metadata, URIs, upload responses, safe stream length extension, and custom JSON serialization for MediaUri.
backend/LexBoxApi/GraphQL/LexQueries.cs, frontend/schema.graphql	Added GraphQL query and schema for media files, metadata, filtering, sorting, and pagination with admin authorization.
frontend/viewer/src/lib/components/audio/AudioDialog.svelte, frontend/viewer/src/lib/components/audio/audio-editor.svelte, frontend/viewer/src/lib/components/field-editors/audio-input.svelte, frontend/viewer/src/lib/components/field-editors/multi-ws-input.svelte, frontend/viewer/src/lib/components/field-editors/rich-multi-ws-input.svelte	Updated audio upload UI, added file size validation, improved file naming, and enhanced event handling for audio input components with two-way bindings and onchange callbacks.
frontend/viewer/src/lib/dotnet-types/generated-types/FwLiteShared/Services/IMiniLcmJsInvokable.ts, frontend/viewer/src/lib/dotnet-types/generated-types/FwLiteShared/Services/IReadFileResponseJs.ts, frontend/viewer/src/lib/dotnet-types/generated-types/MiniLcm/Media/ILcmFileMetadata.ts, frontend/viewer/src/lib/dotnet-types/generated-types/MiniLcm/Media/IMediaFile.ts, frontend/viewer/src/lib/dotnet-types/generated-types/MiniLcm/Media/IUploadFileResponse.ts, frontend/viewer/src/lib/dotnet-types/generated-types/MiniLcm/Media/MediaFileType.ts, frontend/viewer/src/lib/dotnet-types/generated-types/MiniLcm/Media/UploadFileResult.ts	Added or updated TypeScript interfaces and enums for media file types, metadata, upload responses, and .NET interop.
frontend/viewer/src/lib/services/service-provider-dotnet.ts	Refactored .NET interop to support streaming blobs and array buffers, updated type handling, and improved argument transformation for service calls.
backend/harmony	Updated subproject reference to a new commit.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~80 minutes

Possibly related PRs

show audio fields to play back audio for FW classic projects #1775: Related changes in FwDataMiniLcmApi.cs for media file streaming and path handling.

Suggested reviewers

rmunn

Poem

A hop, a skip, a media leap—
Now files can flow and safely keep.
Audio uploads, schemas grow,
TypeScript learns what backend knows.
With blobs and streams, the bytes all dance,
This rabbit gives your code a glance—
And cheers your files' new circumstance! 🐇🎶

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch save-audio

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-07-22T02:58:19Z

UI unit Tests

1 files ±0 38 suites ±0 20s ⏱️ -1s
80 tests ±0 80 ✅ ±0 0 💤 ±0 0 ❌ ±0
111 runs ±0 111 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit a82cf76. ± Comparison against base commit b21e444.

♻️ This comment has been updated with latest results.

github-actions · 2025-07-22T02:59:41Z

C# Unit Tests

126 tests ±0 126 ✅ ±0 12s ⏱️ ±0s
20 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit a82cf76. ± Comparison against base commit b21e444.

♻️ This comment has been updated with latest results.

argos-ci · 2025-07-22T03:00:10Z

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Jul 29, 2025, 7:14 AM

coderabbitai

Actionable comments posted: 5

🧹 Nitpick comments (3)

backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs (1)
1579-1588: Consider adding validation for MIME type parameter.

The TypeToLinkedFolder method correctly maps MIME types to folders, but consider adding validation to handle null or empty MIME type strings gracefully.
 private string TypeToLinkedFolder(string mimeType)
 {
+    if (string.IsNullOrEmpty(mimeType)) return "Others";
     return mimeType switch
     {
         { } s when s.StartsWith("audio/") => AudioVisualFolder,
         {} s when s.StartsWith("video/") => AudioVisualFolder,
         { } s when s.StartsWith("image/") => "Pictures",
         _ => "Others"
     };
 }
backend/FwLite/MiniLcm/Media/UploadFileResponse.cs (1)
5-29: Consider adding factory methods for better API clarity

The multiple constructors with different validation rules could be confusing for consumers. Consider adding static factory methods for clearer intent:
 public record UploadFileResponse
 {
+    public static UploadFileResponse Success(MediaUri mediaUri, bool savedToLexbox) 
+        => new(mediaUri, savedToLexbox);
+    
+    public static UploadFileResponse Failure(UploadFileResult result) 
+        => new(result);
+    
+    public static UploadFileResponse Error(string errorMessage) 
+        => new(errorMessage);
+
     public UploadFileResponse(MediaUri mediaUri, bool savedToLexbox)
     {
         MediaUri = mediaUri;
         Result = savedToLexbox ? UploadFileResult.SavedToLexbox : UploadFileResult.SavedLocally;
     }
This would make the API usage more explicit and self-documenting.
frontend/viewer/src/lib/components/audio/AudioDialog.svelte (1)
109-133: Consider adding support for additional audio formats

The MIME type mapping could include more formats for better compatibility:
         case 'audio/m4a':
           return 'm4a';
+        case 'audio/flac':
+          return 'flac';
+        case 'audio/opus':
+          return 'opus';
+        case 'audio/3gpp':
+        case 'audio/3gpp2':
+          return '3gp';
         default:
           return 'audio';

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d12ad66 and bcac0b5.

📒 Files selected for processing (36)

backend/FwHeadless/LexboxFwDataMediaAdapter.cs (1 hunks)
backend/FwLite/FwDataMiniLcmBridge.Tests/MediaFileTests.cs (1 hunks)
backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs (2 hunks)
backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateDictionaryProxy.cs (1 hunks)
backend/FwLite/FwDataMiniLcmBridge/Media/IMediaAdapter.cs (1 hunks)
backend/FwLite/FwDataMiniLcmBridge/Media/LocalMediaAdapter.cs (2 hunks)
backend/FwLite/FwLiteShared/Services/MiniLcmJsInvokable.cs (3 hunks)
backend/FwLite/FwLiteShared/Sync/SyncService.cs (4 hunks)
backend/FwLite/FwLiteShared/TypeGen/ReinforcedFwLiteTypingConfig.cs (6 hunks)
backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs (2 hunks)
backend/FwLite/LcmCrdt/MediaServer/IMediaServerClient.cs (1 hunks)
backend/FwLite/LcmCrdt/MediaServer/LcmMediaService.cs (3 hunks)
backend/FwLite/MiniLcm/IMiniLcmReadApi.cs (1 hunks)
backend/FwLite/MiniLcm/IMiniLcmWriteApi.cs (2 hunks)
backend/FwLite/MiniLcm/Media/FileMetadata.cs (1 hunks)
backend/FwLite/MiniLcm/Media/MediaFile.cs (1 hunks)
backend/FwLite/MiniLcm/Media/MediaUri.cs (2 hunks)
backend/FwLite/MiniLcm/Media/ReadFileResponse.cs (1 hunks)
backend/FwLite/MiniLcm/Media/UploadFileResponse.cs (1 hunks)
backend/LexBoxApi/GraphQL/LexQueries.cs (1 hunks)
backend/Testing/FwHeadless/MediaFileServiceTests.cs (1 hunks)
backend/harmony (1 hunks)
frontend/schema.graphql (9 hunks)
frontend/viewer/src/lib/components/audio/AudioDialog.svelte (4 hunks)
frontend/viewer/src/lib/components/audio/audio-editor.svelte (1 hunks)
frontend/viewer/src/lib/components/field-editors/audio-input.svelte (4 hunks)
frontend/viewer/src/lib/components/field-editors/multi-ws-input.svelte (1 hunks)
frontend/viewer/src/lib/components/field-editors/rich-multi-ws-input.svelte (3 hunks)
frontend/viewer/src/lib/dotnet-types/generated-types/FwLiteShared/Services/IMiniLcmJsInvokable.ts (2 hunks)
frontend/viewer/src/lib/dotnet-types/generated-types/FwLiteShared/Services/IReadFileResponseJs.ts (1 hunks)
frontend/viewer/src/lib/dotnet-types/generated-types/MiniLcm/Media/ILcmFileMetadata.ts (1 hunks)
frontend/viewer/src/lib/dotnet-types/generated-types/MiniLcm/Media/IMediaFile.ts (1 hunks)
frontend/viewer/src/lib/dotnet-types/generated-types/MiniLcm/Media/IUploadFileResponse.ts (1 hunks)
frontend/viewer/src/lib/dotnet-types/generated-types/MiniLcm/Media/MediaFileType.ts (1 hunks)
frontend/viewer/src/lib/dotnet-types/generated-types/MiniLcm/Media/UploadFileResult.ts (1 hunks)
frontend/viewer/src/lib/services/service-provider-dotnet.ts (4 hunks)

🧠 Learnings (15)

backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateDictionaryProxy.cs (2)

Learnt from: hahn-kev
PR: #1609
File: backend/FwLite/LcmCrdt/CompiledModels/ComplexFormComponentEntityType.cs:138-182
Timestamp: 2025-04-17T02:52:44.986Z
Learning: Files in the LcmCrdt.CompiledModels namespace contain auto-generated Entity Framework Core model code that should be ignored during code reviews since they shouldn't be manually modified.

Learnt from: hahn-kev
PR: #1760
File: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs:274-277
Timestamp: 2025-06-27T09:24:39.507Z
Learning: In the CrdtMiniLcmApi class, the user prefers to keep the current AddChanges method signature (IEnumerable) rather than modifying it to support IAsyncEnumerable for streaming, even when it means materializing collections into memory for bulk operations.

backend/FwLite/MiniLcm/Media/ReadFileResponse.cs (1)

Learnt from: hahn-kev
PR: #1609
File: backend/FwLite/LcmCrdt/CompiledModels/ComplexFormComponentEntityType.cs:138-182
Timestamp: 2025-04-17T02:52:44.986Z
Learning: Files in the LcmCrdt.CompiledModels namespace contain auto-generated Entity Framework Core model code that should be ignored during code reviews since they shouldn't be manually modified.

backend/Testing/FwHeadless/MediaFileServiceTests.cs (1)

Learnt from: hahn-kev
PR: #1804
File: backend/FwLite/LcmCrdt/CurrentProjectService.cs:18-19
Timestamp: 2025-07-07T06:02:41.194Z
Learning: In the CurrentProjectService class, the service locator pattern is intentionally used to retrieve IDbContextFactory and EntrySearchServiceFactory because these services indirectly depend on CurrentProjectService to have the current project set, creating a circular dependency. This is an acceptable use of service locator to break the circular dependency while keeping project context responsibility consolidated.

backend/FwLite/FwDataMiniLcmBridge/Media/IMediaAdapter.cs (1)

Learnt from: hahn-kev
PR: #1760
File: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs:274-277
Timestamp: 2025-06-27T09:24:39.507Z
Learning: In the CrdtMiniLcmApi class, the user prefers to keep the current AddChanges method signature (IEnumerable) rather than modifying it to support IAsyncEnumerable for streaming, even when it means materializing collections into memory for bulk operations.

backend/FwLite/MiniLcm/IMiniLcmReadApi.cs (1)

Learnt from: hahn-kev
PR: #1760
File: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs:274-277
Timestamp: 2025-06-27T09:24:39.507Z
Learning: In the CrdtMiniLcmApi class, the user prefers to keep the current AddChanges method signature (IEnumerable) rather than modifying it to support IAsyncEnumerable for streaming, even when it means materializing collections into memory for bulk operations.

frontend/viewer/src/lib/components/audio/audio-editor.svelte (3)

Learnt from: hahn-kev
PR: #1710
File: frontend/viewer/src/project/browse/BrowseView.svelte:17-19
Timestamp: 2025-05-27T06:18:33.852Z
Learning: The NewEntryButton component in frontend/viewer/src/project/NewEntryButton.svelte already internally checks features.write permission and conditionally renders based on write access, so external disabled props are not needed.

Learnt from: myieye
PR: #1817
File: frontend/viewer/src/lib/components/audio/wavesurfer/waveform.svelte:52-66
Timestamp: 2025-07-11T15:28:28.240Z
Learning: In the frontend/viewer audio components using WaveSurfer.js, errors from wavesurfer.load() and wavesurfer.loadBlob() methods are handled automatically by the system's error handling mechanism, so manual try-catch blocks are not needed.

Learnt from: myieye
PR: #1817
File: frontend/viewer/src/lib/components/audio/wavesurfer/waveform.svelte:65-65
Timestamp: 2025-07-11T15:30:24.410Z
Learning: In the frontend/viewer audio components using WaveSurfer.js, the manual call to wavesurfer.play() after loading audio should be removed because WaveSurfer automatically handles playback when configured with the autoplay option, making manual play() calls redundant.

backend/FwLite/MiniLcm/IMiniLcmWriteApi.cs (1)

Learnt from: hahn-kev
PR: #1760
File: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs:274-277
Timestamp: 2025-06-27T09:24:39.507Z
Learning: In the CrdtMiniLcmApi class, the user prefers to keep the current AddChanges method signature (IEnumerable) rather than modifying it to support IAsyncEnumerable for streaming, even when it means materializing collections into memory for bulk operations.

backend/FwLite/FwLiteShared/Sync/SyncService.cs (2)

Learnt from: hahn-kev
PR: #1804
File: backend/FwLite/LcmCrdt/CurrentProjectService.cs:18-19
Timestamp: 2025-07-07T06:02:41.194Z
Learning: In the CurrentProjectService class, the service locator pattern is intentionally used to retrieve IDbContextFactory and EntrySearchServiceFactory because these services indirectly depend on CurrentProjectService to have the current project set, creating a circular dependency. This is an acceptable use of service locator to break the circular dependency while keeping project context responsibility consolidated.

Learnt from: hahn-kev
PR: #1609
File: backend/FwLite/LcmCrdt/CompiledModels/ComplexFormComponentEntityType.cs:138-182
Timestamp: 2025-04-17T02:52:44.986Z
Learning: Files in the LcmCrdt.CompiledModels namespace contain auto-generated Entity Framework Core model code that should be ignored during code reviews since they shouldn't be manually modified.

frontend/viewer/src/lib/components/field-editors/multi-ws-input.svelte (3)

Learnt from: hahn-kev
PR: #1757
File: frontend/viewer/src/lib/components/field-editors/multi-select.svelte:130-136
Timestamp: 2025-06-18T05:13:00.591Z
Learning: In frontend/viewer/src/lib/components/field-editors/multi-select.svelte, the computeCommandScore function from 'bits-ui' handles empty filter strings appropriately and does not hide all options when the filter is empty, contrary to initial analysis assumptions.

Learnt from: hahn-kev
PR: #1827
File: frontend/viewer/src/lib/i18n/LocalizationPicker.svelte:12-15
Timestamp: 2025-07-17T05:09:27.809Z
Learning: In Svelte 5, the bind:value directive supports function binding syntax where you can pass two functions separated by a comma: bind:value={getter, setter}. For example, bind:value={() => $locale, l => setLanguage(l)} is valid syntax where the first function is the getter and the second is the setter. This is not a JavaScript comma operator issue - it's a specific Svelte 5 compiler feature for two-way binding.

Learnt from: hahn-kev
PR: #1710
File: frontend/viewer/src/project/browse/BrowseView.svelte:17-19
Timestamp: 2025-05-27T06:18:33.852Z
Learning: The NewEntryButton component in frontend/viewer/src/project/NewEntryButton.svelte already internally checks features.write permission and conditionally renders based on write access, so external disabled props are not needed.

backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs (3)

Learnt from: hahn-kev
PR: #1760
File: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs:274-277
Timestamp: 2025-06-27T09:24:39.507Z
Learning: In the CrdtMiniLcmApi class, the user prefers to keep the current AddChanges method signature (IEnumerable) rather than modifying it to support IAsyncEnumerable for streaming, even when it means materializing collections into memory for bulk operations.

Learnt from: hahn-kev
PR: #1609
File: backend/FwLite/LcmCrdt/CompiledModels/ComplexFormComponentEntityType.cs:138-182
Timestamp: 2025-04-17T02:52:44.986Z
Learning: Files in the LcmCrdt.CompiledModels namespace contain auto-generated Entity Framework Core model code that should be ignored during code reviews since they shouldn't be manually modified.

Learnt from: hahn-kev
PR: #1804
File: backend/FwLite/LcmCrdt/CurrentProjectService.cs:18-19
Timestamp: 2025-07-07T06:02:41.194Z
Learning: In the CurrentProjectService class, the service locator pattern is intentionally used to retrieve IDbContextFactory and EntrySearchServiceFactory because these services indirectly depend on CurrentProjectService to have the current project set, creating a circular dependency. This is an acceptable use of service locator to break the circular dependency while keeping project context responsibility consolidated.

backend/FwLite/FwLiteShared/Services/MiniLcmJsInvokable.cs (3)

Learnt from: hahn-kev
PR: #1760
File: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs:274-277
Timestamp: 2025-06-27T09:24:39.507Z
Learning: In the CrdtMiniLcmApi class, the user prefers to keep the current AddChanges method signature (IEnumerable) rather than modifying it to support IAsyncEnumerable for streaming, even when it means materializing collections into memory for bulk operations.

Learnt from: hahn-kev
PR: #1609
File: backend/FwLite/LcmCrdt/CompiledModels/ComplexFormComponentEntityType.cs:138-182
Timestamp: 2025-04-17T02:52:44.986Z
Learning: Files in the LcmCrdt.CompiledModels namespace contain auto-generated Entity Framework Core model code that should be ignored during code reviews since they shouldn't be manually modified.

Learnt from: hahn-kev
PR: #1804
File: backend/FwLite/LcmCrdt/CurrentProjectService.cs:18-19
Timestamp: 2025-07-07T06:02:41.194Z
Learning: In the CurrentProjectService class, the service locator pattern is intentionally used to retrieve IDbContextFactory and EntrySearchServiceFactory because these services indirectly depend on CurrentProjectService to have the current project set, creating a circular dependency. This is an acceptable use of service locator to break the circular dependency while keeping project context responsibility consolidated.

frontend/viewer/src/lib/components/field-editors/audio-input.svelte (3)

Learnt from: myieye
PR: #1817
File: frontend/viewer/src/lib/components/audio/wavesurfer/waveform.svelte:65-65
Timestamp: 2025-07-11T15:30:24.410Z
Learning: In the frontend/viewer audio components using WaveSurfer.js, the manual call to wavesurfer.play() after loading audio should be removed because WaveSurfer automatically handles playback when configured with the autoplay option, making manual play() calls redundant.

Learnt from: hahn-kev
PR: #1757
File: frontend/viewer/src/lib/components/field-editors/multi-select.svelte:130-136
Timestamp: 2025-06-18T05:13:00.591Z
Learning: In frontend/viewer/src/lib/components/field-editors/multi-select.svelte, the computeCommandScore function from 'bits-ui' handles empty filter strings appropriately and does not hide all options when the filter is empty, contrary to initial analysis assumptions.

Learnt from: myieye
PR: #1817
File: frontend/viewer/src/lib/components/audio/wavesurfer/waveform.svelte:52-66
Timestamp: 2025-07-11T15:28:28.240Z
Learning: In the frontend/viewer audio components using WaveSurfer.js, errors from wavesurfer.load() and wavesurfer.loadBlob() methods are handled automatically by the system's error handling mechanism, so manual try-catch blocks are not needed.

frontend/viewer/src/lib/components/field-editors/rich-multi-ws-input.svelte (2)

Learnt from: hahn-kev
PR: #1757
File: frontend/viewer/src/lib/components/field-editors/multi-select.svelte:130-136
Timestamp: 2025-06-18T05:13:00.591Z
Learning: In frontend/viewer/src/lib/components/field-editors/multi-select.svelte, the computeCommandScore function from 'bits-ui' handles empty filter strings appropriately and does not hide all options when the filter is empty, contrary to initial analysis assumptions.

Learnt from: myieye
PR: #1802
File: frontend/viewer/src/project/NewEntryButton.svelte:36-36
Timestamp: 2025-07-04T17:00:57.368Z
Learning: In this codebase, $props.id() (Svelte rune) automatically returns a unique identifier per component instance, so components using it do not require an explicit id prop from parents.

frontend/viewer/src/lib/components/audio/AudioDialog.svelte (2)

Learnt from: myieye
PR: #1817
File: frontend/viewer/src/lib/components/audio/wavesurfer/waveform.svelte:52-66
Timestamp: 2025-07-11T15:28:28.240Z
Learning: In the frontend/viewer audio components using WaveSurfer.js, errors from wavesurfer.load() and wavesurfer.loadBlob() methods are handled automatically by the system's error handling mechanism, so manual try-catch blocks are not needed.

Learnt from: myieye
PR: #1817
File: frontend/viewer/src/lib/components/audio/wavesurfer/waveform.svelte:65-65
Timestamp: 2025-07-11T15:30:24.410Z
Learning: In the frontend/viewer audio components using WaveSurfer.js, the manual call to wavesurfer.play() after loading audio should be removed because WaveSurfer automatically handles playback when configured with the autoplay option, making manual play() calls redundant.

backend/FwLite/LcmCrdt/MediaServer/LcmMediaService.cs (1)

Learnt from: hahn-kev
PR: #1760
File: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs:274-277
Timestamp: 2025-06-27T09:24:39.507Z
Learning: In the CrdtMiniLcmApi class, the user prefers to keep the current AddChanges method signature (IEnumerable) rather than modifying it to support IAsyncEnumerable for streaming, even when it means materializing collections into memory for bulk operations.

🧬 Code Graph Analysis (4)

backend/FwHeadless/LexboxFwDataMediaAdapter.cs (2)

backend/FwHeadless/Media/MediaFileService.cs (2)

MediaFile (72-89)

MediaFile (91-94)

backend/LexCore/Entities/MediaFile.cs (1)

MediaFile (8-41)

frontend/viewer/src/lib/dotnet-types/generated-types/MiniLcm/Media/IMediaFile.ts (1)

frontend/viewer/src/lib/dotnet-types/generated-types/MiniLcm/Media/ILcmFileMetadata.ts (1)

ILcmFileMetadata (6-12)

backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs (3)

backend/FwLite/FwDataMiniLcmBridge/Media/LocalMediaAdapter.cs (2)

MediaUri (31-38)

MediaUri (40-43)

backend/FwLite/MiniLcm/Media/MediaUri.cs (4)

MediaUri (12-16)

MediaUri (18-21)

MediaUri (23-29)

MediaUri (47-52)

backend/FwLite/FwDataMiniLcmBridge/Media/IMediaAdapter.cs (1)

MediaUri (15-15)

frontend/viewer/src/lib/dotnet-types/generated-types/FwLiteShared/Services/IMiniLcmJsInvokable.ts (2)

frontend/viewer/src/lib/dotnet-types/generated-types/MiniLcm/Media/ILcmFileMetadata.ts (1)

ILcmFileMetadata (6-12)

frontend/viewer/src/lib/dotnet-types/generated-types/MiniLcm/Media/IUploadFileResponse.ts (1)

IUploadFileResponse (8-13)

🧰 Additional context used