Skip to content

Fail build if any i18n strings were not extracted #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 31, 2025
Merged

Fail build if any i18n strings were not extracted #1864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
578825d
Fail build if any i18n strings were not extracted
rmunn Jul 31, 2025
64c2911
Fix quoting in "Please run pnpm i18n:extract" line
rmunn Jul 31, 2025
e058614
Printing blank lines gets omitted in GHA logs
rmunn Jul 31, 2025
60d484f
Exit verify-i18n step on any unexpected failures
rmunn Jul 31, 2025
76b692f
Much simpler test for unextracted strings
rmunn Jul 31, 2025
3801ace
Run i18n checking step *before* Playwright
rmunn Jul 31, 2025
0169cf8
Back to shell script, lingui doesn't do what we need
rmunn Jul 31, 2025
82c4f3c
Fix partially-missing script
rmunn Jul 31, 2025
0225252
stop running lingui extract twice
hahn-kev Jul 31, 2025
69fb096
update locales
hahn-kev Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion .github/workflows/fw-lite.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,34 @@ jobs:
working-directory: frontend
run: |
pnpm install
- name: Ensure all i18n strings have been extracted
working-directory: frontend/viewer
shell: bash
run: |
set -e
# GHA sets -o pipefail when shell is bash but we want to turn it off
set +o pipefail
rm -f src/locales/en.po.old
cp src/locales/en.po src/locales/en.po.old
pnpm i18n:extract
DIFFCOUNT=$(diff -u src/locales/en.po{.old,} | grep '+msgid' | wc -l)
if [ $DIFFCOUNT -gt 0 ]; then
# Unextracted strings found, fail the build
echo '***'
echo $DIFFCOUNT unextracted strings found:
echo '***'
diff -u src/locales/en.po{.old,} | grep '+msgid' | cut -c2-
echo '***'
echo Please run pnpm i18n:extract
exit 1
fi
rm -f src/locales/en.po.old
- name: Set up Playwright dependencies
working-directory: frontend
run: pnpm exec playwright install --with-deps
- name: Run snapshot tests
working-directory: frontend/viewer
run: task playwright-test-standalone

- name: Build viewer
working-directory: frontend/viewer
run: pnpm run build
Expand Down
2 changes: 1 addition & 1 deletion frontend/viewer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"check": "svelte-check",
"lint": "eslint .",
"lint:report": "eslint . --output-file eslint_report.json --format json",
"i18n:extract": "lingui extract --clean && lingui extract",
"i18n:extract": "lingui extract --clean",
"generate-icon-types": "node ./generate-icon-types.js",
"storybook": "storybook dev -p 6006 --host 0.0.0.0",
"build-storybook": "storybook build"
Expand Down
48 changes: 37 additions & 11 deletions frontend/viewer/src/locales/en.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ msgstr "Account"
msgid "Activity"
msgstr "Activity"

#: src/lib/components/field-editors/audio-input.svelte:206
#: src/lib/components/audio/AudioDialog.svelte:106
#: src/lib/components/field-editors/audio-input.svelte:213
#: src/lib/components/audio/AudioDialog.svelte:153
msgid "Add audio"
msgstr "Add audio"

Expand Down Expand Up @@ -126,10 +126,18 @@ msgstr "Application version"
msgid "Are you sure you want to delete {0}?"
msgstr "Are you sure you want to delete {0}?"

#: src/lib/components/field-editors/audio-input.svelte:215
#: src/lib/components/field-editors/audio-input.svelte:222
msgid "Audio file not included in Send & Receive"
msgstr "Audio file not included in Send & Receive"

#: src/lib/components/audio/AudioDialog.svelte:82
msgid "Audio saved and uploaded to Lexbox"
msgstr "Audio saved and uploaded to Lexbox"

#: src/lib/components/audio/AudioDialog.svelte:79
msgid "Audio saved locally"
msgstr "Audio saved locally"

#: src/lib/history/HistoryView.svelte:95
#: src/lib/activity/ActivityView.svelte:91
msgid "Author:"
Expand Down Expand Up @@ -160,7 +168,7 @@ msgstr "Browse"
#: src/lib/entry-editor/EntryOrSensePicker.svelte:245
#: src/lib/components/field-editors/select.svelte:166
#: src/lib/components/field-editors/multi-select.svelte:280
#: src/lib/components/audio/AudioDialog.svelte:118
#: src/lib/components/audio/AudioDialog.svelte:167
msgid "Cancel"
msgstr "Cancel"

Expand Down Expand Up @@ -399,14 +407,27 @@ msgstr "Field Labels"
msgid "FieldWorks logo"
msgstr "FieldWorks logo"

#: src/lib/components/audio/AudioDialog.svelte:89
msgid "File already exists"
msgstr "File already exists"

#: src/lib/components/audio/audio-editor.svelte:32
msgid "File name:"
msgstr "File name:"

#: src/lib/components/field-editors/audio-input.svelte:74
#: src/lib/components/field-editors/audio-input.svelte:79
msgid "File not found"
msgstr "File not found"

#: src/lib/components/audio/AudioDialog.svelte:87
msgid "File saving not supported"
msgstr "File saving not supported"

#: src/lib/components/audio/AudioDialog.svelte:164
#: src/lib/components/audio/AudioDialog.svelte:85
msgid "File too big"
msgstr "File too big"

#: src/project/browse/SearchFilter.svelte:100
msgid "Filter # entries"
msgstr "Filter # entries"
Expand Down Expand Up @@ -587,7 +608,7 @@ msgstr "New Entry"
msgid "No activity found"
msgstr "No activity found"

#: src/lib/components/field-editors/audio-input.svelte:210
#: src/lib/components/field-editors/audio-input.svelte:217
msgid "No audio"
msgstr "No audio"

Expand All @@ -604,6 +625,10 @@ msgstr "No Dictionaries found"
msgid "No entries found"
msgstr "No entries found"

#: src/lib/components/audio/AudioDialog.svelte:75
msgid "No file selected"
msgstr "No file selected"

#: src/lib/history/HistoryView.svelte:66
msgid "No history found"
msgstr "No history found"
Expand Down Expand Up @@ -645,7 +670,7 @@ msgstr "Note"
msgid "Offline"
msgstr "Offline"

#: src/lib/components/field-editors/audio-input.svelte:77
#: src/lib/components/field-editors/audio-input.svelte:82
msgid "Offline, unable to download"
msgstr "Offline, unable to download"

Expand Down Expand Up @@ -712,19 +737,19 @@ msgstr "Refresh Projects"
msgid "Remove"
msgstr "Remove"

#: src/lib/components/field-editors/audio-input.svelte:261
#: src/lib/components/field-editors/audio-input.svelte:268
msgid "Remove audio"
msgstr "Remove audio"

#: src/lib/OpenInFieldWorksButton.svelte:41
msgid "Reopen"
msgstr "Reopen"

#: src/lib/components/field-editors/audio-input.svelte:258
#: src/lib/components/field-editors/audio-input.svelte:265
msgid "Replace audio"
msgstr "Replace audio"

#: src/lib/components/audio/AudioDialog.svelte:120
#: src/lib/components/audio/AudioDialog.svelte:169
msgid "Save audio"
msgstr "Save audio"

Expand Down Expand Up @@ -877,10 +902,11 @@ msgid "Unknown"
msgstr "Unknown"

#: src/project/ProjectSidebar.svelte:115
#: src/lib/components/audio/AudioDialog.svelte:91
msgid "Unknown error"
msgstr "Unknown error"

#: src/lib/components/field-editors/audio-input.svelte:80
#: src/lib/components/field-editors/audio-input.svelte:85
msgid "Unknown error {0}"
msgstr "Unknown error {0}"

Expand Down
49 changes: 37 additions & 12 deletions frontend/viewer/src/locales/es.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ msgstr "Cuenta"
msgid "Activity"
msgstr "Actividad"

#: src/lib/components/field-editors/audio-input.svelte:206
#: src/lib/components/audio/AudioDialog.svelte:106
#: src/lib/components/field-editors/audio-input.svelte:213
#: src/lib/components/audio/AudioDialog.svelte:153
msgid "Add audio"
msgstr "Añadir audio"

Expand Down Expand Up @@ -131,10 +131,18 @@ msgstr "Versión de la aplicación"
msgid "Are you sure you want to delete {0}?"
msgstr "¿Estás seguro de que quieres borrar {0}?"

#: src/lib/components/field-editors/audio-input.svelte:215
#: src/lib/components/field-editors/audio-input.svelte:222
msgid "Audio file not included in Send & Receive"
msgstr "Archivo de audio no incluido en Enviar y Recibir"

#: src/lib/components/audio/AudioDialog.svelte:82
msgid "Audio saved and uploaded to Lexbox"
msgstr ""

#: src/lib/components/audio/AudioDialog.svelte:79
msgid "Audio saved locally"
msgstr ""

#: src/lib/history/HistoryView.svelte:95
#: src/lib/activity/ActivityView.svelte:91
msgid "Author:"
Expand Down Expand Up @@ -165,7 +173,7 @@ msgstr "Visite"
#: src/lib/entry-editor/EntryOrSensePicker.svelte:245
#: src/lib/components/field-editors/select.svelte:166
#: src/lib/components/field-editors/multi-select.svelte:280
#: src/lib/components/audio/AudioDialog.svelte:118
#: src/lib/components/audio/AudioDialog.svelte:167
msgid "Cancel"
msgstr "Cancelar"

Expand Down Expand Up @@ -404,14 +412,27 @@ msgstr "Etiquetas de campo"
msgid "FieldWorks logo"
msgstr "Logotipo de FieldWorks"

#: src/lib/components/audio/AudioDialog.svelte:89
msgid "File already exists"
msgstr ""

#: src/lib/components/audio/audio-editor.svelte:32
msgid "File name:"
msgstr "Nombre del fichero:"

#: src/lib/components/field-editors/audio-input.svelte:74
#: src/lib/components/field-editors/audio-input.svelte:79
msgid "File not found"
msgstr "Archivo no encontrado"

#: src/lib/components/audio/AudioDialog.svelte:87
msgid "File saving not supported"
msgstr ""

#: src/lib/components/audio/AudioDialog.svelte:164
#: src/lib/components/audio/AudioDialog.svelte:85
msgid "File too big"
msgstr ""

#: src/project/browse/SearchFilter.svelte:100
msgid "Filter # entries"
msgstr "Filtro # entradas"
Expand Down Expand Up @@ -592,7 +613,7 @@ msgstr "Nueva entrada"
msgid "No activity found"
msgstr "No se ha encontrado actividad"

#: src/lib/components/field-editors/audio-input.svelte:210
#: src/lib/components/field-editors/audio-input.svelte:217
msgid "No audio"
msgstr "Sin audio"

Expand All @@ -609,6 +630,10 @@ msgstr "No se han encontrado diccionarios"
msgid "No entries found"
msgstr "No se han encontrado entradas"

#: src/lib/components/audio/AudioDialog.svelte:75
msgid "No file selected"
msgstr ""

#: src/lib/history/HistoryView.svelte:66
msgid "No history found"
msgstr "No se han encontrado antecedentes"
Expand Down Expand Up @@ -650,7 +675,7 @@ msgstr "Nota"
msgid "Offline"
msgstr "Fuera de línea"

#: src/lib/components/field-editors/audio-input.svelte:77
#: src/lib/components/field-editors/audio-input.svelte:82
msgid "Offline, unable to download"
msgstr "Desconectado, no se puede descargar"

Expand Down Expand Up @@ -717,19 +742,19 @@ msgstr "Actualizar proyectos"
msgid "Remove"
msgstr "Eliminar"

#: src/lib/components/field-editors/audio-input.svelte:261
#: src/lib/components/field-editors/audio-input.svelte:268
msgid "Remove audio"
msgstr "Eliminar audio"

#: src/lib/OpenInFieldWorksButton.svelte:41
msgid "Reopen"
msgstr "Vuelva a abrir"

#: src/lib/components/field-editors/audio-input.svelte:258
#: src/lib/components/field-editors/audio-input.svelte:265
msgid "Replace audio"
msgstr "Sustituir audio"

#: src/lib/components/audio/AudioDialog.svelte:120
#: src/lib/components/audio/AudioDialog.svelte:169
msgid "Save audio"
msgstr "Guardar audio"

Expand Down Expand Up @@ -882,10 +907,11 @@ msgid "Unknown"
msgstr "Desconocido"

#: src/project/ProjectSidebar.svelte:115
#: src/lib/components/audio/AudioDialog.svelte:91
msgid "Unknown error"
msgstr "Error desconocido"

#: src/lib/components/field-editors/audio-input.svelte:80
#: src/lib/components/field-editors/audio-input.svelte:85
msgid "Unknown error {0}"
msgstr "Error desconocido {0}"

Expand Down Expand Up @@ -942,4 +968,3 @@ msgstr "Sistema de escritura: {0}"
#: src/project/browse/filter/WsSelect.svelte:29
msgid "Writing Systems"
msgstr "Sistemas de escritura"

Loading
Loading