Skip to content

Conversation

myieye
Copy link
Collaborator

@myieye myieye commented Aug 22, 2025

Fixes #1892
(the fast and dirty way)

Boom! 😉

So, we just try it out, right?

Published PR versions seem to stick around, so this feels fine:
image

Copy link

coderabbitai bot commented Aug 22, 2025

📝 Walkthrough

Walkthrough

Pins Storybook-related devDependencies in frontend/viewer/package.json to a specific pre-release tag (0.0.0-pr-32289-sha-5b7a0231), replacing ^9.0.18 ranges. Updates occur twice within the devDependencies sections. No changes to scripts or runtime dependencies.

Changes

Cohort / File(s) Summary of Changes
DevDependency version pinning
frontend/viewer/package.json
Replaced ^9.0.18 with 0.0.0-pr-32289-sha-5b7a0231 for: @storybook/addon-a11y, @storybook/addon-docs, @storybook/addon-vitest, @storybook/svelte-vite, eslint-plugin-storybook, storybook. Identical pinning applied in two devDependencies blocks. No script or runtime dependency edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

📦 Lexbox

Suggested reviewers

  • hahn-kev

Poem

Hippity hop, I tweak and pin,
Dev deps snug like a carrot tin.
Storybook stars on a prerelease sky,
Two neat spots—oh my, oh my!
Thump of the paw, commit is in—
Now watch these tales of UI spin. 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6e42500 and 034f1ee.

⛔ Files ignored due to path filters (1)
  • frontend/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • frontend/viewer/package.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Build API / publish-api
  • GitHub Check: Build UI / publish-ui
  • GitHub Check: check-and-lint
  • GitHub Check: frontend
  • GitHub Check: frontend-component-unit-tests
  • GitHub Check: Build FW Lite and run tests
🔇 Additional comments (2)
frontend/viewer/package.json (2)

62-62: Double-check eslint-plugin-storybook and Storybook CLI compatibility

It looks like our sandbox lint check failed because the eslint binary wasn’t found, not because of a rule conflict. Please verify on your local environment (with all dependencies installed) that pinning to the 0.0.0-pr-… build doesn’t break linting or Storybook builds:

• Run pnpm install in frontend/viewer to ensure all deps are present.
• Verify ESLint still passes with the fast-PR plugin:

cd frontend/viewer
pnpm exec eslint .

• Smoke-test Storybook with a dry-run build:

pnpm exec storybook build --dry-run

If either step errors—indicating an incompatibility between the temporary 0.0.0-* tag and your current ESLint/Node setup or Chromatic/CI scripts—please address before merging.

optional nit: If this pin is only temporary, open a tracking ticket to revert back to a catalog:^9.x version once the upstream PR merges. That way Renovate or Dependabot can pick up the real release automatically.


44-49: Confirm Storybook PR versions are published; full install & runtime tests still required

  • Verified that all pinned Storybook packages exist on npm at 0.0.0-pr-32289-sha-5b7a0231 (addon-a11y, addon-docs, addon-vitest, svelte-vite).
  • A lockfile-only install in frontend/viewer completed without any peer-dependency warnings under pnpm v10.12.3.

Next steps before merging:

  • In frontend/viewer, run a full install (e.g. pnpm install --ignore-scripts or standard pnpm install) to catch any peer-dep resolution errors.
  • Boot the Storybook dev server (pnpm run storybook dev) and verify all addons load correctly.
  • Run the Vitest suite against the Storybook project to ensure no subtle runtime mismatches.

Optional refactor: instead of hard-pinning in devDependencies, consider keeping them on "catalog:" and using a root-level pnpm.overrides block for the fast PR build. This preserves workspace conventions and makes rollbacks trivial.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch use-fast-pr-32289-storybook

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Aug 22, 2025
Copy link

github-actions bot commented Aug 22, 2025

UI unit Tests

  1 files  ±  0   40 suites  +37   16s ⏱️ +16s
 82 tests + 72   82 ✅ + 72  0 💤 ±0  0 ❌ ±0 
116 runs  +106  116 ✅ +106  0 💤 ±0  0 ❌ ±0 

Results for commit 034f1ee. ± Comparison against base commit 6e42500.

This pull request removes 10 and adds 82 tests. Note that renamed tests count towards both.
src/index.test.ts ‑ password hashing > can hash a pw using sha1
src/lib/i18n/i18n.test.ts ‑ buildRegionalLocaleRegex > should find all regional locales for available locales
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return en by default
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return en if no user locale is provided and acceptLanguageHeader does not have any supported locales
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return regional locale from acceptLanguageHeader if it has a higher quality rating than the regionless locale
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return supported locale from acceptLanguageHeader with highest quality rating if no user locale is provided
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader does not provide a regional/more specific locale
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader does not provide a regional/more specific locale with a higher quality rating
src/lib/i18n/i18n.test.ts ‑ pickBestLocale > should return user locale if acceptLanguageHeader is not provided
src/lib/user.test.ts ‑ jwtToUser > should convert a jwt token to a LexAuthUser
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > accepts parent values when not dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > does NOT guard against stomping deep changes, because StompGuard can't detect them
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > ignores parent values when dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > initializes with the parent value
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > keeps subscribers up to date when it becomes dirty
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > pushs changes to parent
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > reverts new parent values when ignored
src/lib/components/stomp/stomp-guard.svelte.test.ts ‑ StompGuard > starts accepting parent changes again after a flush
src/lib/components/ui/format/format-duration.test.ts ‑ formatDuration > formats durations
src/lib/components/ui/format/format-duration.test.ts ‑ formatDuration > formats durations with smallest unit
…

♻️ This comment has been updated with latest results.

Copy link

argos-ci bot commented Aug 22, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Aug 22, 2025, 9:33 AM

Copy link

C# Unit Tests

130 tests  ±0   130 ✅ ±0   18s ⏱️ -1s
 20 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 034f1ee. ± Comparison against base commit 6e42500.

Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's do it, and then go back to non-PR Storybook versions once this PR is included in a release.

@myieye myieye merged commit 142b156 into develop Aug 27, 2025
23 checks passed
@myieye myieye deleted the use-fast-pr-32289-storybook branch August 27, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Research Storybook alternatives esp. KitBook

2 participants