-
-
Notifications
You must be signed in to change notification settings - Fork 4
Make sync result message clearer and add FW loading state #2027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
myieye
wants to merge
14
commits into
develop
Choose a base branch
from
adapt-sync-messages
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
defa998
Adapt sync message so it's more balanced
myieye 6f88154
Add pulse animations for loading sync-state values
myieye 036800f
Reword sync result message
myieye 2f25730
i18n:extract
myieye 9fd7c7c
Add accordian component
myieye 8a42486
Make SyncDialog a drawer on mobile
myieye da409cd
Make sync arrows responsive
myieye 17f5f70
Put commit counts and explanation behind tooltip
myieye c9f1235
Prevent ms from being used in sync dialog
myieye 3c93511
i18n:extract
myieye e0f1e24
Use new shimmer animation for loading-text
myieye d9a7204
Make relative-date tooltip target include date
myieye 1788113
Clarify sync tabs with titles, tooltip and new name
myieye 319b463
i18n:extract
myieye File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
// used in the is-mobile.svelte hook | ||
// used in the is-mobile.svelte hook and for the tailwind md breakpoint | ||
export const MOBILE_BREAKPOINT = 768; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
frontend/viewer/src/lib/components/ui/accordion/accordion-content.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<script lang="ts"> | ||
import { Accordion as AccordionPrimitive, type WithoutChild } from 'bits-ui'; | ||
import { cn } from '$lib/utils.js'; | ||
|
||
let { | ||
ref = $bindable(null), | ||
class: className, | ||
children, | ||
...restProps | ||
}: WithoutChild<AccordionPrimitive.ContentProps> = $props(); | ||
</script> | ||
|
||
<AccordionPrimitive.Content | ||
bind:ref | ||
class={cn( | ||
'data-[state=closed]:animate-accordion-up data-[state=open]:animate-accordion-down overflow-hidden text-sm transition-all', | ||
className, | ||
)} | ||
{...restProps} | ||
> | ||
<div class="pb-4 pt-0"> | ||
{@render children?.()} | ||
</div> | ||
</AccordionPrimitive.Content> |
8 changes: 8 additions & 0 deletions
8
frontend/viewer/src/lib/components/ui/accordion/accordion-item.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<script lang="ts"> | ||
import { Accordion as AccordionPrimitive } from 'bits-ui'; | ||
import { cn } from '$lib/utils.js'; | ||
|
||
let { ref = $bindable(null), class: className, ...restProps }: AccordionPrimitive.ItemProps = $props(); | ||
</script> | ||
|
||
<AccordionPrimitive.Item bind:ref class={cn('border-b', className)} {...restProps} /> |
29 changes: 29 additions & 0 deletions
29
frontend/viewer/src/lib/components/ui/accordion/accordion-trigger.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
<script lang="ts"> | ||
import { Accordion as AccordionPrimitive, type WithoutChild } from 'bits-ui'; | ||
import { cn } from '$lib/utils.js'; | ||
import { Icon } from '../icon'; | ||
|
||
let { | ||
ref = $bindable(null), | ||
class: className, | ||
level = 3, | ||
children, | ||
...restProps | ||
}: WithoutChild<AccordionPrimitive.TriggerProps> & { | ||
level?: AccordionPrimitive.HeaderProps['level']; | ||
} = $props(); | ||
</script> | ||
|
||
<AccordionPrimitive.Header {level} class="flex"> | ||
<AccordionPrimitive.Trigger | ||
bind:ref | ||
class={cn( | ||
'flex flex-1 items-center justify-between py-4 font-medium transition-all hover:underline [&[data-state=open]>.i-mdi-chevron-down]:rotate-180', | ||
className, | ||
)} | ||
{...restProps} | ||
> | ||
{@render children?.()} | ||
<Icon icon="i-mdi-chevron-down" class="size-4 shrink-0 transition-transform duration-200" /> | ||
</AccordionPrimitive.Trigger> | ||
</AccordionPrimitive.Header> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import {Accordion as AccordionPrimitive} from 'bits-ui'; | ||
import Content from './accordion-content.svelte'; | ||
import Item from './accordion-item.svelte'; | ||
import Trigger from './accordion-trigger.svelte'; | ||
// eslint-disable-next-line @typescript-eslint/naming-convention | ||
const Root = AccordionPrimitive.Root; | ||
|
||
export { | ||
Root, | ||
Content, | ||
Item, | ||
Trigger, | ||
// | ||
Root as Accordion, | ||
Content as AccordionContent, | ||
Item as AccordionItem, | ||
Trigger as AccordionTrigger, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.