Fix LT-21729: Crash deleting phoneme features set (#322)

* Force new version for debugging purposes

* Fix LT-21729: Crash deleting phoneme feature set

Author: jtmaxwell3

src/SIL.LCModel/DomainImpl/OverridesLing_Lex.cs

@@ -7644,15 +7644,23 @@ protected override void RemoveObjectSideEffectsInternal(RemoveObjectEventArgs e)
 				if (removedCtxt != null)
 				{
 					var featConstrs = GetFeatureConstraintsExcept(removedCtxt);
-					foreach (var constr in removedCtxt.PlusConstrRS)
+					foreach (var constr in removedCtxt.PlusConstrRS.ToList())
 					{
 						if (!featConstrs.Contains(constr))
+						{
+							// Remove constr from removedCtxt first to avoid deleting removedCtxt twice (fixes LT-21729).
+							removedCtxt.PlusConstrRS.Remove(constr);
 							m_cache.LanguageProject.PhonologicalDataOA.FeatConstraintsOS.Remove(constr);
+						}
 					}
-					foreach (var constr in removedCtxt.MinusConstrRS)
+					foreach (var constr in removedCtxt.MinusConstrRS.ToList())
 					{
 						if (!featConstrs.Contains(constr))
+						{
+							// Remove constr from removedCtxt first to avoid deleting removedCtxt twice.
+							removedCtxt.MinusConstrRS.Remove(constr);
 							m_cache.LanguageProject.PhonologicalDataOA.FeatConstraintsOS.Remove(constr);
+						}
 					}
 				}
 			}