Skip to content

Fix LT-21729: Crash deleting phoneme features set #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtmaxwell3 merged 2 commits into from
Mar 13, 2025
Merged

Fix LT-21729: Crash deleting phoneme features set #322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cec773
Force new version for debugging purposes
jtmaxwell3 Mar 13, 2025
ce62c32
Fix LT-21729: Crash deleting phoneme feature set
jtmaxwell3 Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/SIL.LCModel/DomainImpl/OverridesLing_Lex.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7644,15 +7644,23 @@ protected override void RemoveObjectSideEffectsInternal(RemoveObjectEventArgs e)
if (removedCtxt != null)
{
var featConstrs = GetFeatureConstraintsExcept(removedCtxt);
foreach (var constr in removedCtxt.PlusConstrRS)
foreach (var constr in removedCtxt.PlusConstrRS.ToList())
{
if (!featConstrs.Contains(constr))
{
// Remove constr from removedCtxt first to avoid deleting removedCtxt twice (fixes LT-21729).
removedCtxt.PlusConstrRS.Remove(constr);
m_cache.LanguageProject.PhonologicalDataOA.FeatConstraintsOS.Remove(constr);
}
}
foreach (var constr in removedCtxt.MinusConstrRS)
foreach (var constr in removedCtxt.MinusConstrRS.ToList())
{
if (!featConstrs.Contains(constr))
{
// Remove constr from removedCtxt first to avoid deleting removedCtxt twice.
removedCtxt.MinusConstrRS.Remove(constr);
m_cache.LanguageProject.PhonologicalDataOA.FeatConstraintsOS.Remove(constr);
}
}
}
}
Expand Down
Loading