Fix LT-22110: Intermittent crash in Segment.get_AnalysesRS #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonleenaylor
approved these changes
May 2, 2025
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
(sigh)
More evidence that a model change which versions the text so that analyses are never invalidated is warrented.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Segment is no longer valid, then Segment.AnalysesRS crashes. This tends to happen if the user edits the baseline text after analyzing some of the text. This happens to Mark Bean a lot. I fixed all of the places that he got a crash, but there are more than a hundred references to Segent.AnalysesRS in liblcm. It would be nice if Segment.AnalysesRS could return a dummy AnalysesRS or something when the Segment is not valid to avoid crashes.
This change is