Skip to content

Conversation

@jtmaxwell3
Copy link
Contributor

@jtmaxwell3 jtmaxwell3 commented May 8, 2025

A06-Kurdish uses A to represent a separate character from a. But the icu locale thinks that A is the capital of a. This means that the analysis guesser guesses analyses based on ras for rAs. One easy way to fix this would be to change the A to U+0391 GREEK CAPITAL LETTER ALPHA, but the data is from outside the project. An alternative is to only try lowercase analyses if the first letter of the wordform is uppercase. This will still guess ras for RAs, but getting it to guess rAs instead would require a lot more work since there are several places in FieldWorks where it is assumed that you use ToLower to lowercase words.


This change is Reviewable

@github-actions
Copy link

github-actions bot commented May 8, 2025

LCM Tests

    16 files  ±0      16 suites  ±0   3m 5s ⏱️ -2s
 2 831 tests +1   2 811 ✅ +1   20 💤 ±0  0 ❌ ±0 
11 272 runs  +4  11 104 ✅ +4  168 💤 ±0  0 ❌ ±0 

Results for commit 6610e6c. ± Comparison against base commit 69b6c0a.

♻️ This comment has been updated with latest results.

@imnasnainaec
Copy link

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@jtmaxwell3 jtmaxwell3 merged commit 7fd440c into master May 9, 2025
5 checks passed
@jtmaxwell3 jtmaxwell3 deleted the LT-22121 branch May 9, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants