Skip to content

Conversation

@mark-sil
Copy link
Contributor

@mark-sil mark-sil commented Aug 12, 2025

Added to support a fix for LT-22124 in Fieldworks.


This change is Reviewable

@github-actions
Copy link

github-actions bot commented Aug 12, 2025

LCM Tests

    16 files  ±0      16 suites  ±0   2m 53s ⏱️ +5s
 2 837 tests ±0   2 817 ✅ ±0   20 💤 ±0  0 ❌ ±0 
11 296 runs  ±0  11 128 ✅ ±0  168 💤 ±0  0 ❌ ±0 

Results for commit 95da936. ± Comparison against base commit ad2dcf7.

♻️ This comment has been updated with latest results.

Copy link

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion


a discussion (no related file):
Please update the CHANGELOG.


src/SIL.LCModel/InterfaceAdditions.cs line 6009 at r1 (raw file):

		/// the value from the specificItem.</param>
		void SpecificItemAndFieldName(string fieldName, out ICmObject specificItem, out string specificFieldName);

This extra empty line can be removed.


src/SIL.LCModel/DomainImpl/OverridesLing_Lex.cs line 10088 at r1 (raw file):

			{
				var sense = Item as ILexSense;
				if (sense != null)

Could condense to if (fieldName == "HeadWordRef" && Item is ILexSense)


src/SIL.LCModel/DomainImpl/OverridesLing_Lex.cs line 10096 at r1 (raw file):

			{
				var sense = Item as ILexSense;
				if (sense != null)

Could condense to else if (fieldName == "EntryRefsOS" && Item is ILexSense sense)

Added to support a fix for LT-22124 in Fieldworks.
Copy link

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mark-sil)

@mark-sil mark-sil merged commit 4ef37ec into master Aug 12, 2025
4 of 5 checks passed
@mark-sil mark-sil deleted the feature/localcommit2 branch August 12, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants