Skip to content

Allow creating CmTranslations with a guid #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hahn-kev merged 2 commits into from
Sep 26, 2025
Merged

Allow creating CmTranslations with a guid #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44b744a
add create methods to CmTranslationFactory which take a guid
hahn-kev Sep 12, 2025
b306d68
Merge branch 'master' into create-translation-with-guid
hahn-kev Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions src/SIL.LCModel/DomainImpl/FactoryAdditions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1604,30 +1604,46 @@ internal partial class CmTranslationFactory
/// Create a well-formed ICmTranslation which has the owner and Type property set.
/// </summary>
public ICmTranslation Create(IStTxtPara owner, ICmPossibility translationType)
{
return Create(owner, translationType, Guid.NewGuid());
}
/// <summary>
/// Create a well-formed ICmTranslation which has the owner and Type property set.
/// </summary>
public ICmTranslation Create(IStTxtPara owner, ICmPossibility translationType, Guid guid)
{
if (owner == null) throw new ArgumentNullException("owner");
if (translationType == null) throw new ArgumentNullException("translationType");

return Create(owner.TranslationsOC, translationType);
return Create(owner.TranslationsOC, translationType, guid);
}

/// <summary>
/// Create a well-formed ICmTranslation which has the owner and Type property set.
/// </summary>
public ICmTranslation Create(ILexExampleSentence owner, ICmPossibility translationType)
{
return Create(owner, translationType, Guid.NewGuid());
}

/// <summary>
/// Create a well-formed ICmTranslation which has the owner and Type property set.
/// </summary>
public ICmTranslation Create(ILexExampleSentence owner, ICmPossibility translationType, Guid guid)
{
if (owner == null) throw new ArgumentNullException("owner");
if (translationType == null) throw new ArgumentNullException("translationType");

return Create(owner.TranslationsOC, translationType);
return Create(owner.TranslationsOC, translationType, guid);
}

/// <summary>
/// Do the real work for both smart Create methods.
/// </summary>
private ICmTranslation Create(ICollection<ICmTranslation> owningVector, ICmPossibility translationType)
private ICmTranslation Create(ICollection<ICmTranslation> owningVector, ICmPossibility translationType, Guid guid)
{
var newbie = new CmTranslation();
if (guid == Guid.Empty) guid = Guid.NewGuid();
var newbie = new CmTranslation(m_cache, m_cache.InternalServices.DataReader.GetNextRealHvo(), guid);
owningVector.Add(newbie);
newbie.TypeRA = translationType;
return newbie;
Expand Down
10 changes: 10 additions & 0 deletions src/SIL.LCModel/FactoryInterfaceAdditions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,20 @@ public partial interface ICmTranslationFactory
/// </summary>
ICmTranslation Create(IStTxtPara owner, ICmPossibility translationType);

/// <summary>
/// Create a well-formed ICmTranslation which has an owner and Type property set
/// </summary>
ICmTranslation Create(IStTxtPara owner, ICmPossibility translationType, Guid guid);

/// <summary>
/// Create a well-formed ICmTranslation which has an owner and Type property set
/// </summary>
ICmTranslation Create(ILexExampleSentence owner, ICmPossibility translationType);

/// <summary>
/// Create a well-formed ICmTranslation which has an owner and Type property set
/// </summary>
ICmTranslation Create(ILexExampleSentence owner, ICmPossibility translationType, Guid guid);
}

public partial interface ICmTranslation
Expand Down
Loading