Skip to content

Changed build.yml to allow nuget-publish step to publish off version tag#1432

Merged
tombogle merged 1 commit intomasterfrom
allow-nuget-publishing-off-version-tag
May 20, 2025
Merged

Changed build.yml to allow nuget-publish step to publish off version tag#1432
tombogle merged 1 commit intomasterfrom
allow-nuget-publishing-off-version-tag

Conversation

@tombogle
Copy link
Contributor

@tombogle tombogle commented May 20, 2025


This change is Reviewable

@tombogle tombogle self-assigned this May 20, 2025
@tombogle tombogle changed the title Changed build.yml to allow nuget-publish step to publish when build r… Changed build.yml to allow nuget-publish step to publish off version tag May 20, 2025
@github-actions
Copy link

Palaso Tests

     4 files  ±0       4 suites  ±0   11m 13s ⏱️ + 1m 13s
 4 978 tests ±0   4 743 ✅  - 1  235 💤 +1  0 ❌ ±0 
16 186 runs  ±0  15 481 ✅  - 3  705 💤 +3  0 ❌ ±0 

Results for commit e2351dc. ± Comparison against base commit ff51196.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could additionally modify this workflow to trigger a build on a pushed tag as well, but what is important is that we have a process for getting the release packages pushed and this will do that.
:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@tombogle tombogle merged commit 3590b5a into master May 20, 2025
12 checks passed
@tombogle tombogle deleted the allow-nuget-publishing-off-version-tag branch May 20, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants