Skip to content

SP-2372: Fixed handling of links to external URLs in HtmlBrowser (esp in About Box) #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tombogle merged 12 commits into from
Jul 18, 2025
Merged

SP-2372: Fixed handling of links to external URLs in HtmlBrowser (esp in About Box) #1446

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
36aacfd
+semver:minor SP-2372: Fixed handling of links to external URLs in Ht…
tombogle Jul 11, 2025
e320f16
Merge branch 'master' into sp-2372-handle-links-to-external-window-in…
tombogle Jul 11, 2025
a27a74b
Merge branch 'master' into sp-2372-handle-links-to-external-window-in…
tombogle Jul 14, 2025
41a13c9
SP-2372: Comments related to code review
tombogle Jul 14, 2025
08136d1
+semver:minor Added static HtmlUtils class
tombogle Jul 16, 2025
cd5dd1e
SP-2372: Hooked up SILAboutBox to call HtmlUtils.CreatePatchedTempHtm…
tombogle Jul 16, 2025
a4e4a72
SP-2372: Improved regexes in HtmlUtils to allow for single quotes in …
tombogle Jul 16, 2025
66ce3b3
SP-2372: Further improvements to regular expressions in HtmlUtils.
tombogle Jul 16, 2025
0910043
SP-2372: Improved wording in CHANGELOG.md and added another test case
tombogle Jul 16, 2025
65042d1
SP-2372: Further tweaks and additional test cases.
tombogle Jul 17, 2025
4a46c64
SP-2372: Further improvements to HtmlUtils.IsExternalHref + additiona…
tombogle Jul 18, 2025
1934655
SP-2372: A few more review-inspired tweaks
tombogle Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,27 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

## [16.1.0] - 2025-07-17

### Added

- [SIL.Windows.Forms] Added PortableClipboard.CanGetImage()
- [ClipboardTestApp] Restored this test program and added tests for PortableClipboard.CanGetImage() and GetImageFromClipboard()
- [SIL.Windows.Forms] Added SILAboutBox.Navigating and SILAboutBox.Navigated events to allow callers to customize how HTML links in the embedded browser are handled.
- [SIL.Windows.Forms] Added SILAboutBox.AllowExternalLinksToOpenInsideAboutBox property to control whether a `<base target="_blank" rel="noopener noreferrer">` line is automatically added to the HTML (if missing) to ensure links open in the system browser rather than within the About dialog box.
- [SIL.Core] Added static HtmlUtils class with methods for handling HTML to be displayed in browser controls (e.g., `SILAboutBox`), including support for fixing missing target attributes on links and copying simple asset files when creating a temp HTML file to display.

### Fixed

- [SIL.Windows.Forms] In `CustomDropDown.OnOpening`, fixed check that triggers timer to stop.
- [SIL.Windows.Forms] Fixed HtmlBrowserHandled.OnNewWindow to open external URLs (`target="_blank"`) in the system’s default browser instead of Internet Explorer. This improves behavior in SILAboutBox and other components that use the embedded browser.

### Changed

- [SIL.WritingSystems] Updated embedded langtags.json
- [SIL.WritingSystems] Updated embedded ianaSubtagRegistry.txt

- [SIL.Windows.Forms] Improved SILAboutBox to help prevent navigation issues when the supplied HTML contains links but lacks both a <base target="_blank"> element and explicit target="_blank" attributes on the links. If the Navigating event is not handled, such links would otherwise open within the About box itself, often resulting in unexpected behavior. A sensible fallback is now applied automatically to the HTML, and in debug mode, a developer warning is shown.
- [SIL.Windows.Forms] Documented previously undocumented feature: SILAboutBox constructor can accept either a filename or a file URI.

## [16.0.0] - 2025-05-20

Expand Down Expand Up @@ -590,7 +597,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- [SIL.NUnit3Compatibility] new project/package that allows to use NUnit3 syntax with NUnit2
projects

[Unreleased]: https://github.com/sillsdev/libpalaso/compare/v16.0.0...master
[Unreleased]: https://github.com/sillsdev/libpalaso/compare/v16.1.0...master
[16.1.0]: https://github.com/sillsdev/libpalaso/compare/v16.0.0...v16.1.0
[16.0.0]: https://github.com/sillsdev/libpalaso/compare/v15.0.0...v16.0.0
[15.0.0]: https://github.com/sillsdev/libpalaso/compare/v14.1.1...v15.0.0
[14.1.1]: https://github.com/sillsdev/libpalaso/compare/v14.1.0...v14.1.1
Expand Down
Loading
Loading