Skip to content

Modify service start command for audiosrv#1463

Merged
StephenMcConnel merged 1 commit intomasterfrom
FixAudioServiceStart-1
Sep 15, 2025
Merged

Modify service start command for audiosrv#1463
StephenMcConnel merged 1 commit intomasterfrom
FixAudioServiceStart-1

Conversation

@andrew-polk
Copy link
Contributor

@andrew-polk andrew-polk commented Sep 11, 2025

Check if Windows Audio Service is running before starting it.


This change is Reviewable

Check if Windows Audio Service is running before starting it.
@github-actions
Copy link

Palaso Tests

     4 files  ±0       4 suites  ±0   10m 21s ⏱️ -20s
 5 055 tests ±0   4 818 ✅  -  3  233 💤  - 1   4 ❌ + 4 
16 465 runs  ±0  15 729 ✅  - 13  720 💤  - 3  16 ❌ +16 

For more details on these failures, see this check.

Results for commit 535b85f. ± Comparison against base commit 27d8f20.

@jasonleenaylor
Copy link
Contributor

@andrew-polk I think these failures are a result of language data changes, you might have cached data locally?

@andrew-polk
Copy link
Contributor Author

andrew-polk commented Sep 11, 2025

Miscommunication. They were failing for me locally, too. Not langtags data, but Windows CultureInfo change.
I've stacked a PR on top of this one with a workaround (#1464) . Both commits have to the be in a PR together to get the PR build to pass.

Copy link
Member

@StephenMcConnel StephenMcConnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephenMcConnel reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @andrew-polk)

@StephenMcConnel StephenMcConnel merged commit 535b85f into master Sep 15, 2025
6 of 12 checks passed
@StephenMcConnel StephenMcConnel deleted the FixAudioServiceStart-1 branch September 15, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants