Skip to content

Remove scanner and camera buttons for .net 8#1470

Merged
andrew-polk merged 1 commit intomasterfrom
remove_net8_camera_scanner
Oct 2, 2025
Merged

Remove scanner and camera buttons for .net 8#1470
andrew-polk merged 1 commit intomasterfrom
remove_net8_camera_scanner

Conversation

@nabalone
Copy link
Contributor

@nabalone nabalone commented Sep 30, 2025

This change is Reviewable

@nabalone
Copy link
Contributor Author

I have tested this in .net 8 BloomDesktop but not in any .net 4 application

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

Palaso Tests

     4 files  ±0       4 suites  ±0   10m 36s ⏱️ +32s
 5 058 tests ±0   4 825 ✅ ±0  233 💤 ±0  0 ❌ ±0 
16 477 runs  ±0  15 757 ✅ ±0  720 💤 ±0  0 ❌ ±0 

Results for commit 5502d14. ± Comparison against base commit 92ea189.

♻️ This comment has been updated with latest results.

@andrew-polk
Copy link
Contributor

Looks good. Let's add to the changelog.

@nabalone nabalone force-pushed the remove_net8_camera_scanner branch from 9b2e14d to 885bf62 Compare September 30, 2025 19:19
Copy link
Contributor Author

@nabalone nabalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Reviewable status: 0 of 2 files reviewed, all discussions resolved

@nabalone nabalone force-pushed the remove_net8_camera_scanner branch from 885bf62 to 5502d14 Compare September 30, 2025 21:21
Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nabalone)


CHANGELOG.md line 34 at r1 (raw file):

### Removed

- [SIL.Windows.Forms] In .NET 8 builds, removed Scanner and Camera options from the Image Toolbox.

Now that we released 16.2, this needs to go under the [Unreleased] header above.
You'll need to add a new ### Removed

@andrew-polk andrew-polk force-pushed the remove_net8_camera_scanner branch from 5502d14 to 2cb9b87 Compare October 2, 2025 21:09
Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nabalone)

@andrew-polk andrew-polk enabled auto-merge October 2, 2025 21:10
@andrew-polk andrew-polk merged commit c3871ef into master Oct 2, 2025
11 checks passed
@andrew-polk andrew-polk deleted the remove_net8_camera_scanner branch October 2, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants