Skip to content

Handle Chinese autonyms explicitly in IetfLanguageTag #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StephenMcConnel wants to merge 1 commit into from
Closed

Handle Chinese autonyms explicitly in IetfLanguageTag #1475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## [Unreleased]

### Fixed
- [SIL.WritingSystems] Handle Chinese autonyms properly in IetfLanguageTag.GetLocalizedLanguageName().
- [SIL.Windows.Forms] Prevent BetterLabel from responding to OnTextChanged when it has been disposed.

### Changed
Expand Down
9 changes: 9 additions & 0 deletions SIL.WritingSystems/IetfLanguageTag.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1317,6 +1317,15 @@ public static string GetLocalizedLanguageName(string languageTag, string uiLangu
{
return kTraditionalChineseNameInEnglish;
}
else if (generalCode == ChineseSimplifiedTag && uiLanguageTag == ChineseSimplifiedTag)
{
// Chinese autonyms are also messed up in various ways, so we hard-code them here.
return kSimplifiedChineseAutonym;
}
else if (generalCode == ChineseTraditionalTag && uiLanguageTag == ChineseTraditionalTag)
{
return kTraditionalChineseAutonym;
}

// Starting some time around Sept 2025, Windows started returning the "fa" culture
// for CultureInfo.GetCultureInfo("prs"). We actually want to return Dari in that case.
Expand Down
Loading