Skip to content
Merged
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
8347393
Remove Winforms dependency from Metadata and LicenseInfo
aror92 Jun 10, 2025
121f8b1
Fix metadata test
aror92 Sep 10, 2025
e08c0f5
Fix incorrect formatting
aror92 Oct 14, 2025
867f1eb
Fix license class naming
aror92 Oct 14, 2025
fc75ef9
Fix L10NSharp version
aror92 Oct 14, 2025
b3634e8
Fix License Class naming
aror92 Oct 16, 2025
73fca3a
Update test app usings
aror92 Oct 21, 2025
e95cacf
Fix ILicenseWithImage cast
aror92 Oct 28, 2025
08e562d
Working WindowsForms split
aror92 Oct 29, 2025
0b84f03
Fix license class naming
aror92 Nov 4, 2025
20faa75
Add Licenses with new names; rename static methods in bare classes
aror92 Nov 6, 2025
9875706
Add Winforms metadata tests
aror92 Nov 12, 2025
af01423
Fix L10NSharp version number
aror92 Nov 12, 2025
0d78af6
Update CHANGELOG
aror92 Nov 12, 2025
cd7eb47
Fix mediaFile in MetadataBareTests
aror92 Nov 12, 2025
4d87a67
Use Localizer in LicenseInfo instead of L10NSharp.LocalizationManager
aror92 Nov 19, 2025
53ed05e
Dispose mediafiles in MetadataBareTests
aror92 Nov 19, 2025
5edc50c
Remove L10NSharp dependency in SIL.Core
aror92 Nov 19, 2025
7dea421
Fix comments in CCLicense, CCLicenseBare, and CustomLicenseBare
aror92 Nov 21, 2025
98374ee
Rename CC/CustomLicenseBare to CC/CustomLicenseInfo
aror92 Nov 25, 2025
06841ec
Fix CCLicenseInfo naming
aror92 Nov 25, 2025
5ae51d0
Add summaries in Winforms-free classes
aror92 Nov 25, 2025
f789a98
Update refs to CCLicenseInfo and CustomLicenseInfo
aror92 Nov 25, 2025
7ad02b3
Add summary to CreativeCommonsLicense
aror92 Nov 25, 2025
8447409
Rename MetadataBare to MetadataCore
aror92 Dec 3, 2025
ea0fb8c
Fix MetadataCore reference in Metadata
aror92 Dec 3, 2025
84c4699
Fix LoadXmpFile in Metadata & MetadataCore to use virtual/override
aror92 Dec 3, 2025
d961c94
Remove static modifier from LoadProperties
aror92 Dec 9, 2025
756c248
Simplify license checks in Metadata controls via pattern matching
aror92 Dec 9, 2025
d372675
Merge branch 'master' into core.metadata
andrew-polk Dec 9, 2025
a0ad541
Update CHANGELOG
aror92 Dec 9, 2025
5aa26ad
Cleanup mediafile in MetadataTests
aror92 Dec 9, 2025
f4e2040
Initialize mediaFile in metadata tests setup
aror92 Dec 9, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,29 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

### Added
- [SIL.Core.Clearshare] Added new classes MetadataBare, CreativeCommonsLicenseBare, and CustomLicenseBare; these are Winforms-free versions of the classes Metadata, CreativeCommonsLicense, and CustomLicense.

- [SIL.Core.Clearshare and SIL.Windows.Forms.Clearshare] Added LicenseUtils and LicenseWithImageUtils to handle the FromXmp method for creating a license. LicenseUtils constructs a bare license object that is Winforms-independent; LicenseWithImageUtils constructs a Winforms-dependent license object with access to license images.
- [SIL.Core.Clearshare] New methods "GetIsStringAvailableForLangId" and "GetDynamicStringOrEnglish" were added to Localizer for use in LicenseInfo's "GetBestLicenseTranslation" method, to remove LicenseInfo's L10NSharp dependency.
- [SIL.Windows.Forms.Clearshare] New ILicenseWithImage interface handles "GetImage" method for Winforms-dependent licenses, implemented in CreativeCommonsLicense and CustomLicense, and formerly included in LicenseInfo.
- [SIL.Core.Clearshare] New tests MetadataBareTests are based on previous MetadataTests in SIL.Windows.Forms.Clearshare. The tests were updated to use ImageSharp instead of Winforms for handling images.

### Fixed
- [SIL.WritingSystems] Fix IetfLanguageTag.GetGeneralCode to handle cases when zh-CN or zh-TW is a prefix and not the whole string.
- [SIL.Windows.Forms] Prevent BetterLabel from responding to OnTextChanged when it has been disposed.

### Changed

- [SIL.Windows.Forms.Clearshare] BREAKING CHANGE: Made LicenseInfo class independent of Windows Forms and moved it from SIL.Windows.Forms.Clearshare to SIL.Core.Clearshare.
- The FromXmp method was moved to LicenseUtils and LicenseWithImageUtils to construct Winforms-independent and Winforms-dependent license types respectively.
- The FromToken method was moved from LicenseInfo to LicenseWithLogo, so it can return the Winforms-dependent license types. FromToken is only used in libpalaso tests and examples, and a Winforms-independent version of this method is not needed.
- The GetImage method from LicenseInfo was moved to the ILicenseWithImage interface, which is implemented by CreativeCommonsLicense and CustomLicense.
- GetBestLicenseTranslation in LicenseInfo now uses Localizer instead of using L10NSharp.LocalizationManager.

- [SIL.Windows.Forms.Clearshare] Winforms-independent metadata and license functionality of Metadata, CreativeCommonsLicense, and CustomLicense were moved to new classes MetadataBare, CreativeCommonsLicenseBare, and CustomLicenseBare in SIL.Core.Clearshare. Metadata, CreativeCommonsLicense, and CustomLicense inherit from the Bare Winforms-free metadata and license versions.
- [SIL.Windows.Forms.Tests.Clearshare] Many tests from MetadataTests in SIL.Windows.Forms.Clearshare were moved to MetadataBareTests in Core.Clearshare. Tests that use Winforms-specific versions of methods (e.g. Metadata.FromFile) were retained. Added checks to test that the correct (Winforms-dependent) License objects are created when loading from xmp, round tripping a license in a png, or saving metadata to tag.
- [SIL.Windows.Forms.Tests.Clearshare] LicenseInfoTests renamed LicenseWithLogoTests.
- [SIL.Windows.Forms] BREAKING CHANGE: Upgraded to L10nSharp v9. Any clients which also use L10nSharp must also upgrade to v9.
- [SIL.Windows.Forms] Add a reference to L10nSharp.Windows.Forms v9.
- [SIL.Windows.Forms.Keyboarding] BREAKING CHANGE: Upgraded to L10nSharp v9. Any clients which also use L10nSharp must also upgrade to v9.
Expand Down
Loading
Loading