PT-3583: Fixed failure with no generated draft, recognize faulted and canceled draft statuses

[tjcouch-sil]

Fixed these problems because I needed to use the Auto Drafts view for testing https://paratextstudio.atlassian.net/browse/PT-3699

This change is 

[irahopkinson]

Thanks for this fix. I noticed it wasn't showing the drafts but was trying to stay in scope of fixing deps. Very happy to see it working again. Feel free to ignore my non-blocking comment.

@irahopkinson reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lyonsil and @tjcouch-sil).

---

src/scripture-forge/src/projects/slingshot-project-data-provider-engine.model.ts line 141 at r1 (raw file):

    if (
      lastCompletedDraftStatus === StatusCodes.NO_CONTENT ||
      lastCompletedDraftStatus === StatusCodes.NOT_FOUND

BTW did you consider using a util function for these repeated checks?

Code quote:

      lastCompletedDraftStatus === StatusCodes.NO_CONTENT ||
      lastCompletedDraftStatus === StatusCodes.NOT_FOUND

[tjcouch-sil]

@tjcouch-sil made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion.

---

src/scripture-forge/src/projects/slingshot-project-data-provider-engine.model.ts line 141 at r1 (raw file):

Previously, irahopkinson (Ira Hopkinson) wrote…

BTW did you consider using a util function for these repeated checks?

I did, but I decided not to for now. Some stuff below used this to narrow the type, and I was too lazy to worry about making a utility function that did all the narrowing just right. Maybe next time we touch it ;) thanks for the review!