Skip to content

Conversation

@Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Dec 17, 2025

  • Specify chapters by chapter number not index
  • Combine chapters into ranges
  • Add special remarks for the 'none' and 'all' cases

Fixes #832. Requires sillsdev/machine#369. Related to sillsdev/silnlp#899.


This change is Reviewable

…anges; add special remarks for the none and all cases
@Enkidu93 Enkidu93 requested a review from ddaspit December 17, 2025 17:54
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 79.31034% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.11%. Comparing base (f5919f2) to head (1615bcf).

Files with missing lines Patch % Lines
...rval.Translation/Services/PretranslationService.cs 79.31% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   66.11%   66.11%   -0.01%     
==========================================
  Files         382      382              
  Lines       20696    20744      +48     
  Branches     2706     2711       +5     
==========================================
+ Hits        13683    13714      +31     
- Misses       6050     6066      +16     
- Partials      963      964       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Enkidu93 Enkidu93 merged commit 3e15d8f into main Dec 19, 2025
2 of 3 checks passed
@Enkidu93 Enkidu93 deleted the improve_quote_denormalization_remark branch December 19, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quotation denormalization remark specifies chapters by index not by chapter number

4 participants