Skip to content

Fix how Node options are specified for build step and production #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nateowami merged 1 commit into from
Dec 4, 2025
Merged

Fix how Node options are specified for build step and production #3603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/release-live.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,5 @@ jobs:
app_suffix: ""
version_number: "${{ needs.determine_version.outputs.next_version }}"
vcs_tag_prefix: "SFv"
node_options: "--optimize_for_size --max_old_space_size=4096"
project: "SIL.XForge.Scripture"
server_domain_name: "scriptureforge.org"
1 change: 0 additions & 1 deletion .github/workflows/release-qa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,5 @@ jobs:
app_suffix: "_qa"
version_number: "${{ needs.determine_version.outputs.next_version }}"
vcs_tag_prefix: "SF-QAv"
node_options: "--optimize_for_size --max_old_space_size=4096"
project: "SIL.XForge.Scripture"
server_domain_name: "qa.scriptureforge.org"
5 changes: 0 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,6 @@ on:
description: "The version number to use for the deployment."
type: string
required: true
node_options:
description: "Node-related options when building RealtimeServer."
type: string
required: true
project:
description: "The project to deploy."
type: string
Expand Down Expand Up @@ -174,7 +170,6 @@ jobs:
DEPLOY_CREDENTIALS: ~/.ssh/deploy_key
HOSTNAME: ${{inputs.server_domain_name}}
ALTERNATE_DOMAIN: ${{secrets.alternate_domain}}
NODE_OPTIONS: ${{inputs.node_options}}
PARATEXT_CLIENT_ID: ${{secrets.paratext_client_id}}
PROJECT: ${{inputs.project}}
SERVAL_CLIENT_ID: ${{secrets.serval_client_id}}
Expand Down
3 changes: 1 addition & 2 deletions scripts/build-and-ship
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ cat <<EOF >"$BUILD_OUTPUT/app/secrets.json"
},
"Site": {
"Origin": "https://${HOSTNAME};${ALTERNATE_DOMAIN}"
},
"node-options": "${NODE_OPTIONS}"
}
}
EOF

Expand Down
2 changes: 1 addition & 1 deletion src/SIL.XForge.Scripture/Startup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public IServiceProvider ConfigureServices(IServiceCollection services)

services.AddSignalR();

string? nodeOptions = Configuration.GetValue<string>("node-options");
string? nodeOptions = Configuration.GetValue<string>("Realtime:NodeOptions");
services.AddSFRealtimeServer(LoggerFactory, Configuration, nodeOptions);

services.AddSFServices();
Expand Down
3 changes: 2 additions & 1 deletion src/SIL.XForge.Scripture/appsettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
"Prefix": "sf"
},
"Realtime": {
"Port": 5003
"Port": 5003,
"NodeOptions": "--optimize_for_size"
},
"Bugsnag": {
"ApiKey": "b72a46a8924a3cd161d4c5534287923c",
Expand Down
Loading