Skip to content

Remove SF_PUSH_KEY from GitHub actions #3760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nateowami wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove SF_PUSH_KEY from GitHub actions #3760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/update-localizations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
persist-credentials: true
Comment on lines 18 to 20
Copy link

@devin-ai-integration devin-ai-integration bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 GITHUB_TOKEN vs SSH deploy key: CI triggers on created PRs

With the SSH deploy key removed, the workflow now relies on GITHUB_TOKEN for authentication. A well-known difference is that PRs created using GITHUB_TOKEN do not trigger subsequent GitHub Actions workflows (e.g., CI checks), whereas PRs created via a deploy key or PAT do. However, since the other analogous workflows (update-font-list.yml:17-19, update-npm-audit.yml:17-19) already operate without an SSH key and presumably work fine, this is likely an accepted tradeoff in this repository. If CI checks running automatically on the created i18n/update PR branch are important, this could be a concern.

(Refers to lines 17-20)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

ssh-key: ${{ secrets.SF_PUSH_KEY }}

- name: Set up Deno
uses: denoland/setup-deno@e95548e56dfa95d4e1a28d6f422fafe75c4c26fb # v2.0.3
Expand Down
Loading