Replaced outdated items and champes with placeholders #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverlight6
requested changes
Sep 26, 2024
Owner
|
Everything looks good except you are missing the most important part. We need a test to make sure the simulator still runs (doesn't crash) after those changes. After that is implemented, I can merge |
silverlight6
requested changes
Sep 30, 2024
Owner
silverlight6
left a comment
silverlight6
left a comment
There was a problem hiding this comment.
Add a unit test or simply move the simulator test to allow for set 12 and make sure it still runs successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the outdated champions and items with placeholders for the current set. Only made changes in abilities.py and items.py. Other files will need to be updated aswell.