FIX Correctly route from non-react to react section.#1984
Conversation
| And I go to "/admin/test" | ||
|
|
||
| Scenario: I can see toast message when I successfully delete a record by clicking the Delete button in action menu | ||
| Given I take a screenshot after every step |
There was a problem hiding this comment.
This shouldn't be there so cleaning that up while I'm here.
Noticed it because I was copying some of the background from this feature.
There was a problem hiding this comment.
Tested locally with replication steps and fix works.
However I tried running the new behat scenario locally with the frameworktest PR installed, and it said that it find something for And I click "behat link to file"
Maybe I'm doing something wrong? Please do a kitchen-sink CI run with the two PRs to demonstrate it working.
|
Kitchen sink is excessive for something that can just be merged one at a time but I'll do a minimal installer run to avoid ping pong. Usually for these low-risk PRs we merge the framework test PR and then rerun CI instead of requiring a separate sink or installer CI run. Not sure when you started requiring those but we don't need them. |
GuySartorelli
force-pushed
the
pulls/2.4/asset-link-routing
branch
6 times, most recently
from
ee5dcb5 to
c512b41
Compare
GuySartorelli
force-pushed
the
pulls/2.4/asset-link-routing
branch
from
c512b41 to
10551fb
Compare
2 participants
Needs silverstripe/silverstripe-frameworktest#243 for new behat test to go green
Issue