FIX remove placeholder search text on readonly field

[andrewandante]

Description

Sets the placeholder text to an empty string on a readonly, "searchable" dropdown.

Also removes a line that sets a $name variable as it is unused in the method

Issues

• disabled searchable dropdown shows "Type to search..." where the field is disabled #11398

Pull request checklist

• The target branch is correct
  • See picking the right version
• All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
  • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
• The commit messages follow our commit message guidelines
• The PR follows our contribution guidelines
• Code changes follow our coding conventions
• This change is covered with tests (or tests aren't necessary for this change)
• Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
• CI is green

[GuySartorelli]

Looks like this isn't used below, which I assume is why you've removed it? Please add a note in future when making changes like this so it's easier to know what's going on.

It's obvious in your IDE because it presumably gets greyed out, but seeing why a change like this was made in a git diff requires more double checking.

[GuySartorelli]

Suggested change

	$this->setUseDynamicPlaceholder(false);
	$field->setUseDynamicPlaceholder(false);

Shouldn't this be called on the field we're returning?

[andrewandante]

Yep, it should. I suspect it won't work because we are now using a different field type, so I'm going to keep playing with this 'til my test passes 🤔

[GuySartorelli]

@andrewandante Let me know when this is ready to review and I'll take another look

[andrewandante]

Thanks - I asked for reproduction steps in the attached issue, I suspect this may also be coming from the React component actually.