ENH Improve GridFieldExportButton csv export filename#11459
Open
3Dgoo wants to merge 1 commit intosilverstripe:5from
Open
ENH Improve GridFieldExportButton csv export filename#114593Dgoo wants to merge 1 commit intosilverstripe:5from
3Dgoo wants to merge 1 commit intosilverstripe:5from
Conversation
3ab48a2 to
c7e771a
Compare
c7e771a to
d871f40
Compare
Contributor
Author
|
To do: Make those two variables yml configurable |
400a755 to
6cc9719
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change improves the GridFieldExportButton csv export filename.
Currently the export filename is always the following no matter what the model is:
With a date format of:
The developer cannot modify this. If the cms user is exporting multiple models, they all have the same name, making it hard to differentiate between exports. The time stamp of d-m-Y-H-i is not necessarily ideal.
This PR changes the default csv export file name to:
With a default date format of:
The
[classname]will automatically be replaced with the model classname. Resulting in the following example filenames:The filename and date format can also be easily changed on a per button basis through the code.
Manual testing steps
Go to the CMS security section:
/admin/security/Press
Export CSV.Observer file name.
Issues
#11458
Pull request checklist