FIX EagerLoading: Don't throw unknown column error when list is empty#11909
Open
beerbohmdo wants to merge 1 commit intosilverstripe:5.4from
Open
FIX EagerLoading: Don't throw unknown column error when list is empty#11909beerbohmdo wants to merge 1 commit intosilverstripe:5.4from
beerbohmdo wants to merge 1 commit intosilverstripe:5.4from
Conversation
2 tasks
889d6e3 to
905976b
Compare
GuySartorelli
requested changes
Nov 28, 2025
Member
GuySartorelli
left a comment
There was a problem hiding this comment.
This PR feels like it's working around a problem that actually lies in getMatches() where the exception is being thrown from. Is there a way to resolve this in that method instead of in each method that calls it?
Contributor
Author
|
The error is thrown in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The EagerLoadedList currently throws an error when the list is empty and you try to filter it.
Manual testing steps
Issues
Pull request checklist