Various changes so we can behat test in the react admin#251
Merged
emteknetnz merged 3 commits intosilverstripe:2from Dec 8, 2025
Merged
Various changes so we can behat test in the react admin#251emteknetnz merged 3 commits intosilverstripe:2from
emteknetnz merged 3 commits intosilverstripe:2from
Conversation
If the form wasn't taking up the entire vertical space, you'd have to scroll even though there's clearly plenty more space to overflow.
This is needed for behat tests
28 tasks
GuySartorelli
commented
Nov 25, 2025
Comment on lines
+74
to
+89
| public function providePermissions() | ||
| { | ||
| $code = static::getRequiredPermissions(); | ||
| $title = LeftAndMain::menu_title(static::class); | ||
| return [ | ||
| $code => [ | ||
| // Item in permission selection identifying the admin section. Example: Access to 'Files & Images' | ||
| 'name' => _t( | ||
| static::class . '.ACCESS', | ||
| "Access to '{title}' section", | ||
| ['title' => $title] | ||
| ), | ||
| 'category' => _t(static::class . '.CMS_ACCESS_CATEGORY', 'CMS Access') | ||
| ] | ||
| ]; | ||
| } |
Member
Author
There was a problem hiding this comment.
Basically a straight copy/paste from LeftAndMain which handles this for model admins
emteknetnz
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple commits:
Needed so the dropdown options are visible without scrolling
Needed so we can access this section without "and I am logged in as ADMIN"
Needed to update the child fields on change
Issue