Skip to content

FIX Drop already-verified check from SessionStore#590

Open
Cheddam wants to merge 1 commit intosilverstripe:5.3from
Cheddam:pulls/5.3/drop-session-store-already-verified-check
Open

FIX Drop already-verified check from SessionStore#590
Cheddam wants to merge 1 commit intosilverstripe:5.3from
Cheddam:pulls/5.3/drop-session-store-already-verified-check

Conversation

@Cheddam
Copy link
Copy Markdown
Member

@Cheddam Cheddam commented Feb 17, 2025

Description

While ostensibly a useful safety check, this validation step is superfluous. The purpose of SessionStore is to hold context for the verification process, not to verify its integrity, and there exist (extremely hard-to-reproduce) edge-cases where this will unhelpfully break the MFA flow.

The MFA method verification process is sufficiently idempotent and safe to prevent any negative outcomes from a method being verified multiple times in a single MFA flow.

Manual testing steps

See reproduction steps in related issue.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

While ostensibly a useful safety check, this validation step is
misplaced. The purpose of SessionStore is to hold context for the
verification process, not to verify its integrity, and there exist
(extremely hard-to-reproduce) edgecases where this will unhelpfully
break the MFA flow.

The MFA method verification process is sufficiently idempotent and
safe to prevent any negative outcomes from a method being verified
multiple times in a single MFA flow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant