FIX Drop already-verified check from SessionStore#590
Open
Cheddam wants to merge 1 commit intosilverstripe:5.3from
Open
FIX Drop already-verified check from SessionStore#590Cheddam wants to merge 1 commit intosilverstripe:5.3from
Cheddam wants to merge 1 commit intosilverstripe:5.3from
Conversation
While ostensibly a useful safety check, this validation step is misplaced. The purpose of SessionStore is to hold context for the verification process, not to verify its integrity, and there exist (extremely hard-to-reproduce) edgecases where this will unhelpfully break the MFA flow. The MFA method verification process is sufficiently idempotent and safe to prevent any negative outcomes from a method being verified multiple times in a single MFA flow.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While ostensibly a useful safety check, this validation step is superfluous. The purpose of SessionStore is to hold context for the verification process, not to verify its integrity, and there exist (extremely hard-to-reproduce) edge-cases where this will unhelpfully break the MFA flow.
The MFA method verification process is sufficiently idempotent and safe to prevent any negative outcomes from a method being verified multiple times in a single MFA flow.
Manual testing steps
See reproduction steps in related issue.
Issues
Pull request checklist