Add mock data and snapshot tests for _FillValue#1750
Merged
Conversation
axelboc
force-pushed
the
fill-value-snapshots
branch
from
1a2e23e to
b187870
Compare
axelboc
commented
Jan 30, 2025
| ...getDomains( | ||
| auxArrays, | ||
| scaleType, | ||
| showErrors ? auxErrorsArrays : undefined, |
Contributor
Author
There was a problem hiding this comment.
We don't pass ignoreValue here, as the expected behaviour for auxiliary signals is not clear. Something to discuss in the future if the user need arises.
Contributor
Author
|
/approve |
loichuder
approved these changes
Jan 31, 2025
| const isIgnored = ignoreValue ? ignoreValue(value) : false; | ||
| const bufferIndex = index * 2; | ||
|
|
||
| if (isIgnored) { |
Member
There was a problem hiding this comment.
I liked the intermediate variable: brain computing .? can be tricky sometime 😅
Contributor
Author
There was a problem hiding this comment.
Haha, I personally found the ternary more difficult to read. 😅 With ?., the fact that ignoreValue is optional doesn't distract as much from the main condition, which is whether or not the value is to be ignored.
axelboc
force-pushed
the
fill-value-snapshots
branch
from
f00d7a0 to
19a39bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_FillValueattribute (and to double check that the fill value is used in the domain computation as expected)._FillValue=400_FillValue=400ignoreValuefeature in the Line and Heatmap visualizations.ignoreValuefunction.useIgnoreFillValueslightly to memoise a few more computations.ignoreValue(anderrorsfor that matter) touseDomain.