Conversation
03d195c to
d8f9748
Compare
Member
|
I would perhaps add the dataset name as the column header for the basic 1D export? |
loichuder
approved these changes
Apr 2, 2025
Comment on lines
+34
to
+36
| csv += isNexus | ||
| ? `${(abscissaParams.value ? abscissaParams.value[i] : i).toString()},` | ||
| : ''; |
Member
There was a problem hiding this comment.
Suggested change
| csv += isNexus | |
| ? `${(abscissaParams.value ? abscissaParams.value[i] : i).toString()},` | |
| : ''; | |
| if(isNexus) { | |
| csv += `${(abscissaParams.value ? abscissaParams.value[i] : i).toString()},` | |
| } |
Contributor
Author
Member
That looks excellent! Good call 👍 |
t20100
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@Blackclaws in #1619 (comment) correctly pointed out that axis values are expected to come first in CSV exports, like in
XYandXYEfiles. Sorry for missing this in #1763.NeXus export with axis values
NeXus export without axis values
The indices are used so that signal values remain in the second column; the column is labelled
x:Basic 1D export
No axis values, no column headers — does that make sense @t20100 @loichuder?