Conversation
axelboc
force-pushed
the
attributes-checks
branch
2 times, most recently
from
f498bba to
0cf5ebc
Compare
axelboc
commented
Jan 30, 2026
axelboc
force-pushed
the
attributes-checks
branch
3 times, most recently
from
3868f02 to
86bea59
Compare
loichuder
approved these changes
Feb 2, 2026
axelboc
force-pushed
the
attributes-checks
branch
from
86bea59 to
0d0b6b3
Compare
axelboc
force-pushed
the
attributes-checks
branch
from
0d0b6b3 to
a927ce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I now make full use of the type guards for type-checking attributes. It's more verbose than before, but it feels a lot safer and cleans up a few tough cases nicely. It even removes the need for
AttrValuesStore#getSingle()— I had struggled with it when attempting the React 19 migration, so taking it out of the equation might help a little.Finally it removes a few cases where we used to call
attrValuesStore#get()directly without checking first if the attributes we're after were present. Hopefully this will save a few requests when working with remote providers.