Open
Conversation
axelboc
force-pushed
the
scatter-ascending
branch
from
3ad90cc to
b5a8a7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1974
< NX Scatter >Force ascending axes regardless of order of axes values.[ScatterVis]Force ascending axes regardless of order of axes values.getAxisDomain,useAxisDomain: addforceAscendingoption to force computed domain to remain ascending regardless of order of axis values.getAxisDomainanduseAxisDomainnow accept an options object as second parameter.I've updated our mock file with descending
xvalues but I'll wait for #1987 to be merged before updating the corresponding screenshot.