Removed usage of FilterBase in public API typing; Replaced FilterBase._init with standard __init__#376
Merged
t20100 merged 3 commits intosilx-kit:mainfrom Feb 25, 2026
Merged
Conversation
type in public API And fix typing issue
payno
approved these changes
Feb 24, 2026
| status = True | ||
| for filter_class in filter_classes: | ||
| filter_name = filter_class.filter_name | ||
| filter_name = cast(FilterBase, filter_class).filter_name |
Member
There was a problem hiding this comment.
You just made me discover the cast 🤩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of PR #373 to address review comment regarding use of
_init.Rework typing to use
h5py.filters.FilterRefBaseinstead ofhdf5plugin.FilterBaseas base class type and update typing accordingly.