Support for grazing-incidence exit angles and polar angle#2380
Merged
kif merged 24 commits intosilx-kit:mainfrom Jan 30, 2025
Merged
Support for grazing-incidence exit angles and polar angle#2380kif merged 24 commits intosilx-kit:mainfrom
kif merged 24 commits intosilx-kit:mainfrom
Conversation
for more information, see https://pre-commit.ci
… grazingincidence_exitangles
Collaborator
Author
|
In the first image, while incident_angle=0.0, the exit angle is 0.0 in q=0, which is also the horizon This example is just for visualize the difference, if the images are integrated using the angle units, there is no missing wedge |
Collaborator
Author
|
In a real example, we would integrate using the angle units: |
for more information, see https://pre-commit.ci
… grazingincidence_exitangles
Collaborator
Author
Collaborator
Author
|
needs to fix #2389 |
added 2 commits
January 23, 2025 15:25
Collaborator
Author
|
Needs to add tests for the different units with scales horizontal and vertical (non-regression) |
kif
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




The units called previously exit angles should be "scattering_angles" in the classic way, because they don't depend on incident and tilt angles. Rotations are applied to q units.
Now, the unit called "exit angle" is used in the grazing-incidence community for the scattering angle with the origin in the horizon of the thin film, now dependant on the incident and tilt angles
The "exit_angles" support is especially useful for SAXS experiments