equivalence azimuth and radial units#2395
Merged
kif merged 10 commits intosilx-kit:mainfrom Jan 30, 2025
Merged
Conversation
Member
|
Overall, it looks good. Can you implement a non-regression test, just on the radial & azimuthal range values... |
for more information, see https://pre-commit.ci
added 2 commits
January 29, 2025 21:51
Collaborator
Author
|
Now, the integrations with/without chi_discontinuity_at_zero, with degrees/radians: Script: |
kif
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


From #2389