Skip to content

Conversation

@kif
Copy link
Member

@kif kif commented Nov 17, 2025

Other minor change: perform relative imports instead of absolute imports.

@kif kif requested review from EdgarGF93 and t20100 November 17, 2025 13:28
@kif kif added gui Affects only the graphical user interface ready to merge Please review work in progress Don't review and removed ready to merge Please review labels Nov 17, 2025
@kif kif added ready to merge Please review and removed work in progress Don't review labels Nov 17, 2025
@kif
Copy link
Member Author

kif commented Nov 17, 2025

Validated PyQt5, PyQt6 and PySide6 on linux

@t20100
Copy link
Member

t20100 commented Nov 20, 2025

I don't understand the need for patch_exec.
exec should be supported by PyQt6, PySide6 and PyQt5. With which binding/version you don't have it?

@t20100 t20100 mentioned this pull request Nov 20, 2025
2 tasks
@kif
Copy link
Member Author

kif commented Nov 20, 2025

@EdgarGF93 could you provide those details ?

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kif
Copy link
Member Author

kif commented Nov 21, 2025

@t20100: On the one hand, you are right, it works with exec() even under PyQt5, but not under PyQt6 where there are issues with exec_() (and other ...).

As first stage, I will replace all exec_() with exec() and then seek your help to fix PyQt6.

@t20100
Copy link
Member

t20100 commented Nov 21, 2025

With which version of pyqt6 do you have the problem?

@kif
Copy link
Member Author

kif commented Nov 22, 2025

I think I will merge this PR but not close the issue ... since it does not address it

@kif kif mentioned this pull request Nov 22, 2025
@kif kif merged commit 67ce7c5 into silx-kit:main Nov 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gui Affects only the graphical user interface ready to merge Please review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants