skip known broken opencl tests on apple hardware #2702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@gudlot can you test on your computer ? (without the "-o" option) |
Member
Author
|
Testing on a computer with python3.12, MacOSX 10.13 and OpenCL: Apparently, all OpenCL test supposed to pass are passing: |
Collaborator
|
Hi Jerome, I tested PR #2702 on my current Mac: MacBook Pro (2019, Intel/AMD)
I ran: All CPU-based tests passed. OpenCL-dependent tests were skipped. I also tried using POCL (CPU OpenCL), but PyOpenCL still could not find any platforms on macOS. This seems related to Apple’s deprecation of OpenCL in favor of Metal. My output with ======================================================================
SKIPPED: runTest (pyFAI.gui.test.SkipGuiTest.runTest)
----------------------------------------------------------------------
pyFAI.gui tests disabled (Skipped by command line)
======================================================================
SKIPPED: test_histo (pyFAI.test.test_azimuthal_integrator.TestIntergrationNextGeneration.test_histo)
----------------------------------------------------------------------
Skipping TestIntergrationNextGeneration.test_histo as OpenCL method not available
======================================================================
SKIPPED: test_hexagonal_detector (pyFAI.test.test_detector.TestDetector.test_hexagonal_detector)
----------------------------------------------------------------------
SplitPixel does not work (yet) with hexagonal pixels: pos.shape[0] == size
======================================================================
SKIPPED: test_sparse_fullsplit (pyFAI.test.test_sparse.TestSparseIntegrate2d.test_sparse_fullsplit)
----------------------------------------------------------------------
Fix this test
======================================================================
SKIPPED: test_opencl_csr (pyFAI.test.test_csr.TestCSR.test_opencl_csr)
----------------------------------------------------------------------
Test on OpenCL disabled
======================================================================
SKIPPED: test_bug_2538 (pyFAI.test.test_bug_regression.TestBugRegression.test_bug_2538)
This bug is creating an infinite loop when some bins have no contributing pixels
SKIPPED: test_add (pyFAI.opencl.test.test_addition.TestAddition.test_add)
tests the addition kernel
SKIPPED: test_measurement (pyFAI.opencl.test.test_addition.TestAddition.test_measurement)
tests that all devices are working properly ...
SKIPPED: test_preproc (pyFAI.opencl.test.test_preproc.TestPreproc.test_preproc)
tests the preproc kernel
SKIPPED: test_histogram1d (pyFAI.opencl.test.test_ocl_histo.TestOclHistogram.test_histogram1d)
tests the 1d histogram kernel
SKIPPED: test_histogram2d (pyFAI.opencl.test.test_ocl_histo.TestOclHistogram.test_histogram2d)
tests the 2D histogram kernel
SKIPPED: test_integrate_ng (pyFAI.opencl.test.test_ocl_azim_csr.TestOclAzimCSR.test_integrate_ng)
tests the 1d histogram kernel, default block size
SKIPPED: test_integrate_ng_single (pyFAI.opencl.test.test_ocl_azim_csr.TestOclAzimCSR.test_integrate_ng_single)
tests the 1d histogram kernel, default block size
SKIPPED: test_medfilt (pyFAI.opencl.test.test_ocl_azim_csr.TestOclAzimCSR.test_medfilt)
tests the median filtering kernel, default block size
SKIPPED: test_sigma_clip (pyFAI.opencl.test.test_ocl_azim_csr.TestOclAzimCSR.test_sigma_clip)
tests the sigma-clipping kernel, default block size
SKIPPED: test_integrate_ng (pyFAI.opencl.test.test_ocl_azim_lut.TestOclAzimLUT.test_integrate_ng)
tests the 1d histogram kernel
SKIPPED: test_azimuthal_peak_finder (pyFAI.opencl.test.test_peak_finder.TestOclPeakFinder.test_azimuthal_peak_finder)
test for peak picker with background calculate from an azimuthal sigma-clipping
SKIPPED: test_azimuthal_peak_finder_chauvenet (pyFAI.opencl.test.test_peak_finder.TestOclPeakFinder.test_azimuthal_peak_finder_chauvenet)
test for peak picker with background calculate from an azimuthal sigma-clipping
SKIPPED: test_azimuthal_peak_finder_single (pyFAI.opencl.test.test_peak_finder.TestOclPeakFinder.test_azimuthal_peak_finder_single)
test for peak picker with background calculate from an azimuthal sigma-clipping
SKIPPED: test_peakfinder (pyFAI.opencl.test.test_peak_finder.TestOclPeakFinder.test_peakfinder)
test for peakfinder
SKIPPED: test_simple_peak_finder (pyFAI.opencl.test.test_peak_finder.TestOclPeakFinder.test_simple_peak_finder)
test for simple peak picker
SKIPPED: test_Blelloch (pyFAI.opencl.test.test_collective.TestGroupFunction.test_Blelloch)
tests the Blelloch scan function
SKIPPED: test_Blelloch_multipass (pyFAI.opencl.test.test_collective.TestGroupFunction.test_Blelloch_multipass)
tests the Blelloch cumsum using multiple passes ...
SKIPPED: test_Hillis_Steele (pyFAI.opencl.test.test_collective.TestGroupFunction.test_Hillis_Steele)
tests the Hillis_Steele scan function
SKIPPED: test_atomic (pyFAI.opencl.test.test_collective.TestGroupFunction.test_atomic)
tests the sum_int_atomic function
SKIPPED: test_reduction (pyFAI.opencl.test.test_collective.TestGroupFunction.test_reduction)
tests the sum_int_reduction function
SKIPPED: test_sort (pyFAI.opencl.test.test_collective.TestGroupFunction.test_sort)
tests the sort of floating points in a workgroup
SKIPPED: test_sort4 (pyFAI.opencl.test.test_collective.TestGroupFunction.test_sort4)
tests the sort of floating points in a workgroup
----------------------------------------------------------------------
PyOpenCl is missing
======================================================================
SKIPPED: test_opencl (pyFAI.test.test_preproc.TestPreproc.test_opencl)
----------------------------------------------------------------------
OpenCL not available
======================================================================
SKIPPED: testCheckCalib (pyFAI.test.test_scripts.TestScriptsHelp.testCheckCalib)
SKIPPED: testMxcalibrate (pyFAI.test.test_scripts.TestScriptsHelp.testMxcalibrate)
SKIPPED: testPilx (pyFAI.test.test_scripts.TestScriptsHelp.testPilx)
SKIPPED: testPyfaiBenchmark (pyFAI.test.test_scripts.TestScriptsHelp.testPyfaiBenchmark)
SKIPPED: testPyfaiCalib (pyFAI.test.test_scripts.TestScriptsHelp.testPyfaiCalib)
SKIPPED: testPyfaiDrawmask (pyFAI.test.test_scripts.TestScriptsHelp.testPyfaiDrawmask)
SKIPPED: testPyfaiIntegrate (pyFAI.test.test_scripts.TestScriptsHelp.testPyfaiIntegrate)
SKIPPED: testPyfaiRecalib (pyFAI.test.test_scripts.TestScriptsHelp.testPyfaiRecalib)
----------------------------------------------------------------------
no GUI
======================================================================
SKIPPED: test_OpenCL_sigma_clip (pyFAI.opencl.test.test_openCL.TestMask.test_OpenCL_sigma_clip)
SKIPPED: test_OpenCL_sparse (pyFAI.opencl.test.test_openCL.TestMask.test_OpenCL_sparse)
SKIPPED: test_histogram (pyFAI.opencl.test.test_openCL.TestMask.test_histogram)
SKIPPED: test_reference_book (pyFAI.opencl.test.test_openCL.TestSort.test_reference_book)
SKIPPED: test_reference_file (pyFAI.opencl.test.test_openCL.TestSort.test_reference_file)
SKIPPED: test_sort_all (pyFAI.opencl.test.test_openCL.TestSort.test_sort_all)
SKIPPED: test_sort_horizontal (pyFAI.opencl.test.test_openCL.TestSort.test_sort_horizontal)
SKIPPED: test_sort_vertical (pyFAI.opencl.test.test_openCL.TestSort.test_sort_vertical)
SKIPPED: test_dot16 (pyFAI.opencl.test.test_openCL.TestKahan.test_dot16)
SKIPPED: test_kahan (pyFAI.opencl.test.test_openCL.TestKahan.test_kahan)
SKIPPED: test_filter_hor (pyFAI.opencl.test.test_ocl_sort.TestOclSort.test_filter_hor)
SKIPPED: test_filter_vert (pyFAI.opencl.test.test_ocl_sort.TestOclSort.test_filter_vert)
SKIPPED: test_mean_hor (pyFAI.opencl.test.test_ocl_sort.TestOclSort.test_mean_hor)
SKIPPED: test_mean_vert (pyFAI.opencl.test.test_ocl_sort.TestOclSort.test_mean_vert)
SKIPPED: test_sigma_clip_hor (pyFAI.opencl.test.test_ocl_sort.TestOclSort.test_sigma_clip_hor)
SKIPPED: test_sigma_clip_vert (pyFAI.opencl.test.test_ocl_sort.TestOclSort.test_sigma_clip_vert)
SKIPPED: test_sort_hor (pyFAI.opencl.test.test_ocl_sort.TestOclSort.test_sort_hor)
SKIPPED: test_sort_vert (pyFAI.opencl.test.test_ocl_sort.TestOclSort.test_sort_vert)
----------------------------------------------------------------------
OpenCL is not available
======================================================================
SKIPPED: setUpClass (pyFAI.opencl.test.test_openCL.TestDoubleWord)
----------------------------------------------------------------------
OpenCL module (pyopencl) is not present or no device available
======================================================================
SKIPPED: test_opencl (pyFAI.test.test_medfilt_engine.TestMedfilt.test_opencl)
----------------------------------------------------------------------
pyopencl is missing
----------------------------------------------------------------------
Ran 535 tests in 368.194s
OK (skipped=57) |
Member
Author
|
Surprizing you got opencl error without opencl installed ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2560