[Fibert-Unit]simplify code, fix numpy equations, shortcuts for qlab#2772
Merged
kif merged 21 commits intosilx-kit:mainfrom Jan 30, 2026
Merged
[Fibert-Unit]simplify code, fix numpy equations, shortcuts for qlab#2772kif merged 21 commits intosilx-kit:mainfrom
kif merged 21 commits intosilx-kit:mainfrom
Conversation
EdgarGF93
changed the title
Collaborator
Author
for more information, see https://pre-commit.ci
EdgarGF93
added
ready to merge
Collaborator
Author
|
Most of the numpy equations for grazing units were wrong (luckily goes to numexpr all the time), now there is a regression test. I also corrected a little mistake in one of the numexpr equations (a right handed matrix should be left handed) and unify the calculation of rotation matrix, which are now pulled from scipy |
EdgarGF93
added
work in progress
EdgarGF93
added
ready to merge
added 2 commits
January 29, 2026 14:41
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
EdgarGF93
changed the title
Collaborator
Author
|
now it's ready |
Collaborator
Author
kif
reviewed
Jan 30, 2026
Member
|
LGTM |
This was referenced Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.