silx.gui.data.DataViewer: split composite ImageView into Plot2dView and ComplexImageView #4453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loichuder
force-pushed
the
fix-cbar-limits
branch
from
b81ba7e to
38bd1a3
Compare
t20100
approved these changes
Jan 8, 2026
src/silx/gui/data/DataViewer.py
Outdated
| - `DataViews.PLOT1D_MODE`: display the data as a curve | ||
| - `DataViews.IMAGE_MODE`: display the data as an image | ||
| - `DataViews.PLOT2D_MODE`: display real data as an image | ||
| - `DataViews.COMPLEX_IMAGE_MODE`: display complex data as an image |
Member
There was a problem hiding this comment.
COMPLEX_PLOT2D_MODE for consistency with PLOT2D_MODE maybe?
…nd ComplexImageView
loichuder
force-pushed
the
fix-cbar-limits
branch
from
38bd1a3 to
c9da639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Module or Topic>: <Action> <Summary>(see contributing guidelines)Fix #4423
The root cause of #4423 is the fact that the two views (
Plot2dViewandComplexImageView) of the compositeImageVieware updating simultaneously the colorbar dialog (since it is shared for the wholeDataViewer).In specific circumstances, the limits can be set by the view that is not displayed on screen, mismatching the limits of the actual displayed image.
After a long ponder on how to proceed, we decided to split the composite
ImageViewinto two simple viewsPlot2dViewandComplexImageViewso that only one is instantiated at a time. This matches the previous behaviour where only one view over the two is visible at all time but required some minor changes:_ImageViewis now deprecatedComplexImageViewlabel was set toImagefor consistency with the previous behaviourPlot2dViewdoes not support complex anyworeid) of the available visualization changes (from20, it becomes21for a regular image and22for a complex image)