Skip to content

force the foreground color to white for the error background #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

force the foreground color to white for the error background #137

wants to merge 31 commits into from

Conversation

shirne
Copy link

@shirne shirne commented Apr 15, 2022

before
errorfgcolor-orig
after
errorfgcolor

@haarts
Copy link
Collaborator

haarts commented Jun 3, 2022

How does this look on a dark background?

@shirne
Copy link
Author

shirne commented Jun 5, 2022

How does this look on a dark background?

No difference from before.

The text color is just white in dark background. This PR only set the error text to white with red or purple background

@shirne shirne mentioned this pull request Oct 31, 2022
Open
Bungeefan and others added 24 commits February 8, 2023 16:36
@Bungeefan
Updated repository links and added acknowledgment
15ff26a
@Bungeefan
Revert "Remove callbacks"
e6d84b6 
This reverts commit 8dae0e8.
@Bungeefan
Replaced pedantic with lints
bf2c13c
@Bungeefan
Fixed doc reference
77cdd82
@Bungeefan
Added origin LogEvent to OutputEvent, addresses simc#133
a6970d9
@Bungeefan
Updated dart.yml
68767d8
@Bungeefan
Fixed CI shield
45761a6
@Bungeefan
Removed obsolete .travis.yml
a276e6f
@Bungeefan
Bumped version to 1.2.0
0e58c14
@Bungeefan
Reverted ${this} interpolation and added linter ignore, fixes #1
bf4e655
@Bungeefan
Bumped version to 1.2.1
2f940c5
@Bungeefan
Added CI run for Dart SDK 2.17.0
7627472
@Bungeefan
Expose LogOutput class unconditionally
9663000
@Bungeefan
Fixed linter warning, closes simc#3
17675e3
@Bungeefan
Bumped version to 1.2.2
9e9dbdb
@Bungeefan
Added continue-on-error to run CI for all specified SDK versions
57f4ec7
@Bungeefan
Added error handling to LogfmtPrinter
0cc96e2
@Bungeefan
Fixed test imports (removed /src imports)
9a8da9c
@Bungeefan
Fixed stackTrace count when using stackTraceBeginIndex, addresses s…
f7f4779 
…imc#114
@Bungeefan
Added time to LogEvent
1d8d47d
@Bungeefan
Added isClosed, addresses simc#130
6f35b50
@Bungeefan
Removed obsolete linter ignore
985e862
@Bungeefan
Replaced continue-on-error with fail-fast, continues 57f4ec7.
ea8c9c4 
This should enable all jobs to run without being cancelled, while also ensuring that the workflow fails in the event of an error.
@Bungeefan
Added proper FileOutput stub, addresses simc#94
8e3fbea
@Bungeefan Bungeefan mentioned this pull request Feb 27, 2023
Closed
@shirne shirne mentioned this pull request Jun 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shirne @haarts @Bungeefan @Stitch-Taotao