feature: add back arm support #416
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I would recommend merging the PR by @sergiolaverde0 first: #393 as ARM64 builds are very slow. |
Contributor
Author
|
The ARM64 can be tested by the docker image here: ghcr.io/mateuszmrw/linguacafe-python-service:latest |
|
i'm getting |
Contributor
Author
|
@Nimrodium sorry, for some reason the image was changed to private, now it is back to public and should work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR adds back the ARM build.
The only change other than revert of removed native ARM support commit is adding the ENV BLIS_ARCH="generic" and removing rust since it's not needed as build dependency now.
It seems the issue raises when updating the spacy to the new versions as spacy has issues with providing ARM64 wheel versions due to their infrastructure and pip package limitations that should be resolved soon.
I think it would be beneficial to create requirements.txt for python and park spacy and other dependencies versions if the update of them is not necessary.