Compound quoteIdentifier, inline decorator calls, remove SqlProcessor::prepare()

quoteIdentifier() accepts optional second segment for dot-qualified
identifiers (table.column), cached as a single lookup. Identifier::render()
and Columns::toSql() collapse to one call per identifier — eliminates
per-segment loops, array allocations, and implode calls.

Inline decorator dispatch directly in Select/Update/Delete buildSqlString
instead of routing through SqlProcessor::prepare(), avoiding virtual dispatch
overhead on the hot path.

Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>

Author: simon-mundy

src/Adapter/Platform/AbstractPlatform.php

@@ -24,6 +24,8 @@ abstract class AbstractPlatform implements PlatformInterface
 
     protected string $quoteIdentifierTo = '\'';
 
+    protected string $identifierSeparator = '.';
+
     protected bool $quoteIdentifiers = true;
 
     /** @var array<string, string> */
@@ -33,10 +35,24 @@ abstract class AbstractPlatform implements PlatformInterface
      * {@inheritDoc}
      */
     #[Override]
-    public function quoteIdentifier(string $identifier): string
+    public function quoteIdentifier(string $identifier, ?string $identifier2 = null): string
     {
         if (! $this->quoteIdentifiers) {
-            return $identifier;
+            return $identifier2 !== null
+                ? $identifier . $this->identifierSeparator . $identifier2
+                : $identifier;
+        }
+
+        if ($identifier2 !== null) {
+            $key = $identifier . '.' . $identifier2;
+            return $this->identifierCache[$key]
+                ??= $this->quoteIdentifier[0]
+                    . str_replace($this->quoteIdentifier[0], $this->quoteIdentifierTo, $identifier)
+                    . $this->quoteIdentifier[1]
+                    . $this->identifierSeparator
+                    . $this->quoteIdentifier[0]
+                    . str_replace($this->quoteIdentifier[0], $this->quoteIdentifierTo, $identifier2)
+                    . $this->quoteIdentifier[1];
         }
 
         return $this->identifierCache[$identifier]
@@ -111,6 +127,6 @@ public function quoteValueList(array|string $valueList): string
     #[Override]
     public function getIdentifierSeparator(): string
     {
-        return '.';
+        return $this->identifierSeparator;
     }
 }

src/Adapter/Platform/PlatformInterface.php

@@ -24,9 +24,9 @@ public function getSqlPlatformDecorator(): SqlPlatform;
     public function getQuoteIdentifierSymbol(): string;
 
     /**
-     * Quote identifier
+     * Quote identifier — pass two segments for dot-qualified identifiers (e.g. table, column).
      */
-    public function quoteIdentifier(string $identifier): string;
+    public function quoteIdentifier(string $identifier, ?string $identifier2 = null): string;
 
     /**
      * Quote identifier chain

src/Sql/Argument/Identifier.php

@@ -9,7 +9,6 @@
 use PhpDb\Sql\Part\SqlProcessor;
 
 use function explode;
-use function implode;
 
 final readonly class Identifier implements ArgumentInterface
 {
@@ -34,14 +33,6 @@ public function getValue(): string
 
     public function render(SqlProcessor $processor, string $paramPrefix, int &$paramIndex): string
     {
-        if (!isset($this->segments[1])) {
-            return $processor->platform->quoteIdentifier($this->segments[0]);
-        }
-
-        $parts = [];
-        foreach ($this->segments as $s) {
-            $parts[] = $processor->platform->quoteIdentifier($s);
-        }
-        return implode($processor->identifierSeparator, $parts);
+        return $processor->platform->quoteIdentifier($this->segments[0], $this->segments[1] ?? null);
     }
 }

src/Sql/Delete.php

@@ -88,7 +88,7 @@ public function buildSqlString(
     ): string {
         $processor = new SqlProcessor($platform, $driver, $parameterContainer, $sqlPlatform);
         $processor->setParamPrefix($this->processInfo['paramPrefix']);
-        $processor->prepare($this);
+        $sqlPlatform?->getTypeDecorator($this)?->prepare($this, $processor);
 
         return (string) SqlFragment::of($this->getStatementKeyword())
             ->part($this->table->toSql($processor))

src/Sql/Part/Columns.php

@@ -68,16 +68,7 @@ public function toSql(SqlProcessor $processor): ?string
             }
 
             if ($arg instanceof Identifier) {
-                $segments = $arg->segments;
-                if (! isset($segments[1])) {
-                    $columnSql = $fromPrefix . $platform->quoteIdentifier($segments[0]);
-                } else {
-                    $parts = [];
-                    foreach ($segments as $s) {
-                        $parts[] = $platform->quoteIdentifier($s);
-                    }
-                    $columnSql = $fromPrefix . implode($processor->identifierSeparator, $parts);
-                }
+                $columnSql = $fromPrefix . $platform->quoteIdentifier($arg->segments[0], $arg->segments[1] ?? null);
             } else {
                 $columnSql = $processor->renderExpression(
                     $arg->getValue(),
@@ -110,16 +101,7 @@ public function toSql(SqlProcessor $processor): ?string
                     }
 
                     if ($arg instanceof Identifier) {
-                        $segments = $arg->segments;
-                        if (! isset($segments[1])) {
-                            $columnSql = $joinPrefix . $platform->quoteIdentifier($segments[0]);
-                        } else {
-                            $parts = [];
-                            foreach ($segments as $s) {
-                                $parts[] = $platform->quoteIdentifier($s);
-                            }
-                            $columnSql = $joinPrefix . implode($separator, $parts);
-                        }
+                        $columnSql = $joinPrefix . $platform->quoteIdentifier($arg->segments[0], $arg->segments[1] ?? null);
                     } else {
                         $columnSql = $processor->renderExpression(
                             $arg->getValue(),

src/Sql/Part/SqlProcessor.php

@@ -48,15 +48,6 @@ public function setParamPrefix(string $prefix): void
         $this->paramPrefix = $prefix;
     }
 
-    public function prepare(object $subject): void
-    {
-        $this->sqlPlatform?->getTypeDecorator($subject)?->prepare($subject, $this);
-
-        if ($subject instanceof Select) {
-            $subject->tablePart()->prepare($this);
-        }
-    }
-
     public function renderParameter(Parameter $param, ?string $nameOverride = null): string
     {
         if ($this->parameterContainer instanceof ParameterContainer) {

src/Sql/Select.php

@@ -384,7 +384,8 @@ public function buildSqlString(
     ): string {
         $processor = new SqlProcessor($platform, $driver, $parameterContainer, $sqlPlatform);
         $processor->setParamPrefix($this->processInfo['paramPrefix']);
-        $processor->prepare($this);
+        $sqlPlatform?->getTypeDecorator($this)?->prepare($this, $processor);
+        $this->table->prepare($processor);
 
         return (string) SqlFragment::of('SELECT')
             ->part($this->quantifier?->toSql($processor))

src/Sql/Update.php

@@ -134,7 +134,7 @@ public function buildSqlString(
     ): string {
         $processor = new SqlProcessor($platform, $driver, $parameterContainer, $sqlPlatform);
         $processor->setParamPrefix($this->processInfo['paramPrefix']);
-        $processor->prepare($this);
+        $sqlPlatform?->getTypeDecorator($this)?->prepare($this, $processor);
 
         return (string) SqlFragment::of($this->getStatementKeyword())
             ->part($this->table->renderTable($processor))