Update github workflow - add 3.3 and 3.4, remove 2.6, stop updating rubygems #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djberg96
force-pushed
the
github_workflow
branch
from
3626b63 to
1996270
Compare
…- all to make rubocop happy.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the workflow:
The rubygems system update in particular was causing version mismatch errors. Besides, you really don't need it, so it's only slowing things down.
While here, I also addressed 2 rubocop issues that were causing problems. First was that
GLOB_FLAGSwas not properly marked private. Second was thelstat_querymethod, which is nowlstat_query?since it's a boolean method.