Skip to content

Update github workflow - add 3.3 and 3.4, remove 2.6, stop updating rubygems #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update github workflow - add 3.3 and 3.4, remove 2.6, stop updating rubygems #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1996270
Add 3.3 and 3.4, remove 2.6, stop updating rubygems.
djberg96 Oct 3, 2025
ed606e1
Make GLOB_FLAGS properly private, update lstat_query to lstat_query? …
djberg96 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: ['3.2', '3.1', '3.0', '2.7', '2.6']
ruby-version: ['3.4', '3.3', '3.2', '3.1', '3.0', '2.7']

steps:
- uses: actions/checkout@v3
Expand All @@ -25,10 +25,8 @@ jobs:
with:
ruby-version: ${{matrix.ruby-version}}
bundler-cache: true
- name: Updating RubyGems
run: gem update --system
- name: Install dependencies
run: bundle install
run: bundle install --quiet
- name: Rubocop
run: bundle exec rubocop -D
- name: Rspec
Expand Down
5 changes: 3 additions & 2 deletions lib/memfs/dir.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,14 @@ def tell
@pos
end

private

GLOB_FLAGS = if defined?(File::FNM_EXTGLOB)
File::FNM_EXTGLOB | File::FNM_PATHNAME
else
File::FNM_PATHNAME
end
private_constant :GLOB_FLAGS

private

attr_accessor :entry, :max_seek, :state

Expand Down
6 changes: 3 additions & 3 deletions lib/memfs/file.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ def self.symlink(old_name, new_name)
end

def self.symlink?(path)
lstat_query(path, :symlink?)
lstat_query?(path, :symlink?)
end

def self.truncate(path, length)
Expand Down Expand Up @@ -340,10 +340,10 @@ def self.stat_query(path, query, force_boolean: true)
end
private_class_method :stat_query

def self.lstat_query(path, query)
def self.lstat_query?(path, query)
response = fs.find(path) && lstat(path).public_send(query)
!!response
end
private_class_method :lstat_query
private_class_method :lstat_query?
end
end