Add tests for comments inside imports#159
Open
ReneBrandt wants to merge 1 commit intosimonhaenisch:masterfrom
Open
Add tests for comments inside imports#159ReneBrandt wants to merge 1 commit intosimonhaenisch:masterfrom
ReneBrandt wants to merge 1 commit intosimonhaenisch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of PR #143 and bug #144. The issue described still persists with latest typescript 5.9.3 . While removing comments isn't ideal by itself, the issue was slightly aggravated by the fact that I couldn't add a
@ts-expect-errorfor thefrom "my-lib"part of the import statement, as it needs to be added in the places described here and it gets removed.Sorry if this wasn't the intended approach. I see conflicting requests in the issue/PR: you propose to re-open #143 if the issue still persists with latest typescript (it does, but I can't re-open the PR), but also to create an issue with the Typescript repository. I want to help out, so I wouldn't mind creating a bug there, but I am not sure what the issue is or how to describe the behavior.
To save you some time, I decided to recreate the PR so you have the tests readily available. Please let me know if I can help with anything, or if I should have approached this differently.