Fix ComfyUI-Manager initialization and support standard opencv-python (add system GL libs) #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odes This commit modifies the ComfyUI entrypoint script to correctly handle the initialization of ComfyUI-Manager within the persistent `custom_nodes` volume. Changes include: - Added logic to check if `ComfyUI-Manager` (case-insensitive) already exists in the `custom_nodes` directory. - Implemented a robust bash loop for the existence check to avoid issues with `find` on symlinked paths. - If the manager is missing, it is copied from the pre-installed location in the image to the persistent volume. - If the manager exists, the initialization is skipped to prevent overwriting user updates or configurations. This ensures that the pre-installed manager is available on the first run while preserving it across subsequent container restarts and builds.
This commit configures ComfyUI-Manager to enforce `opencv-contrib-python-headless` instead of the standard `opencv-python` package.
Changes:
1. **entrypoint.sh**:
* Dynamically detects if the installed ComfyUI version uses the new System User API (by checking for `get_system_user_directory`).
* Creates the appropriate configuration directory (`__manager` for new versions, `default/ComfyUI-Manager` for old versions) in the user's volume.
* Copies `pip_overrides.json.template` from the image to `pip_overrides.json` in the user configuration directory.
* Displays a prominent notification message during initialization.
This approach ensures that even if custom nodes request the standard OpenCV package, the Manager will intercept the request and install the headless version (specifically the `contrib` variant to support extra modules), preventing system library crashes (libGL) across different ComfyUI versions.
Adios
changed the title
The `ultralytics` package (required by ComfyUI-Impact-Subpack) pulls in `opencv-python` as a dependency. In the headless Docker environment, this caused crashes due to missing GL libraries. Attempting to fix this via `pip_overrides.json` in ComfyUI-Manager (forcing `opencv-python-headless` or `dgenerate-ultralytics-headless`) was problematic because `pip_overrides` struggles with recursive dependency overrides. This commit resolves the issue by installing the necessary system libraries (`libgl1`, `libglib2.0-0`) in the Dockerfile. This allows the standard `opencv-python` wheel to function correctly, eliminating the need for complex override logic in the entrypoint script. Changes: - services/comfy/Dockerfile: Install `libgl1` and `libglib2.0-0`. - services/comfy/entrypoint.sh: Remove `pip_overrides.json` injection logic.
Adios
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two critical issues with the ComfyUI-Manager deployment: ensuring correct initialization in persistent volumes and preventing system library crashes caused by opencv-python.
Many custom nodes (e.g., ComfyUI-Impact-Pack via ultralytics) rely on the standard opencv-python package, which requires system-level GL libraries often missing in headless container environments.
Previously, I attempted to force opencv-python-headless via pip_overrides.json, but this proved unreliable for recursive dependencies.
The updated solution:
This approach ensures a "batteries-included" experience where the Manager and popular nodes (like Impact Pack) work immediately upon first launch without requiring manual user intervention or complex pip overrides.
Closes #15